Re: [PATCH V3 0/4] Large extent counters tests

From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Chandan Babu R <chandan.babu@oracle.com>, fstests@vger.kernel.org
Subject: Re: [PATCH V3 0/4] Large extent counters tests
Date: Thu, 23 Jun 2022 08:23:19 +0800	[thread overview]
Message-ID: <20220623002319.64pqbbpf6ejumcoe@zlang-mailbox> (raw)
In-Reply-To: <YrNLGKchdYqshW4o@magnolia>

On Wed, Jun 22, 2022 at 10:02:16AM -0700, Darrick J. Wong wrote:
> On Sat, Jun 11, 2022 at 04:40:33PM +0530, Chandan Babu R wrote:
> > Hi all,
> > 
> > This patchset adds two tests for verifying the behaviour of Large
> > extent counters feature. It also fixes xfs/270 test failure when
> > executed on a filesystem with Large extent counters enabled.
> > 
> > Changelog:
> > V2 -> V3:
> >    1. xfs/270: Fix regular expresssion used in inline awk script to
> >       match hex number.
> 
> Why did all the patches lose their RVB tags?

Hi Darrick,

Yes, the V3 lost RVB tags, but I saw your RVB on last version, and this V3
only improved a string, so I reviewed it and added your RVB back. I've merged
this patchset. Thanks for your review again :)

Thanks,
Zorro

> 
> --D
> 
> > V1 -> V2:
> >    1. xfs/270: Replace bashisms with inline awk scripts.
> >    2. Use _scratch_mkfs_xfs_supported helper in _require_xfs_nrext64().
> >    3. Remove invocation of $XFS_INFO_PROG from _require_xfs_nrext64().
> >    4. Use xfs_db's 'path' command instead of saving test file's inode
> >       number in the two new tests introduced by the patchset.
> > 
> > Chandan Babu R (4):
> >   xfs/270: Fix ro mount failure when nrext64 option is enabled
> >   common/xfs: Add helper to check if nrext64 option is supported
> >   xfs: Verify that the correct inode extent counters are updated
> >     with/without nrext64
> >   xfs: Verify correctness of upgrading an fs to support large extent
> >     counters
> > 
> >  common/xfs        |  12 +++++
> >  tests/xfs/270     |  26 ++++++++++-
> >  tests/xfs/270.out |   1 -
> >  tests/xfs/547     |  92 +++++++++++++++++++++++++++++++++++++
> >  tests/xfs/547.out |  13 ++++++
> >  tests/xfs/548     | 112 ++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/xfs/548.out |  12 +++++
> >  7 files changed, 265 insertions(+), 3 deletions(-)
> >  create mode 100755 tests/xfs/547
> >  create mode 100644 tests/xfs/547.out
> >  create mode 100755 tests/xfs/548
> >  create mode 100644 tests/xfs/548.out
> > 
> > -- 
> > 2.35.1
> > 
> 