All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Miaoqian Lin <linmq006@gmail.com>
Subject: [PULL 14/14] accel: kvm: Fix memory leak in find_stats_descriptors
Date: Fri, 24 Jun 2022 10:27:30 +0200	[thread overview]
Message-ID: <20220624082730.246924-15-pbonzini@redhat.com> (raw)
In-Reply-To: <20220624082730.246924-1-pbonzini@redhat.com>

From: Miaoqian Lin <linmq006@gmail.com>

This function doesn't release descriptors in one error path,
result in memory leak. Call g_free() to release it.

Fixes: cc01a3f4cadd ("kvm: Support for querying fd-based stats")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Message-Id: <20220624063159.57411-1-linmq006@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 accel/kvm/kvm-all.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index ba3210b1c1..ed8b6b896e 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3891,6 +3891,7 @@ static StatsDescriptors *find_stats_descriptors(StatsTarget target, int stats_fd
         error_setg(errp, "KVM stats: failed to read stats header: "
                    "expected %zu actual %zu",
                    sizeof(*kvm_stats_header), ret);
+        g_free(descriptors);
         return NULL;
     }
     size_desc = sizeof(*kvm_stats_desc) + kvm_stats_header->name_size;
-- 
2.36.1



  parent reply	other threads:[~2022-06-24  8:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  8:27 [PULL 00/14] (Mostly) build system changes for 2022-06-24 Paolo Bonzini
2022-06-24  8:27 ` [PULL 01/14] tests/vm: do not specify -bios option Paolo Bonzini
2022-06-24  8:27 ` [PULL 02/14] pc-bios/optionrom: use -m16 unconditionally Paolo Bonzini
2022-06-24  8:27 ` [PULL 03/14] configure, pc-bios/optionrom: pass cross CFLAGS correctly Paolo Bonzini
2022-06-24  8:27 ` [PULL 04/14] configure, pc-bios/s390-ccw: " Paolo Bonzini
2022-06-24  8:27 ` [PULL 05/14] configure, pc-bios/vof: " Paolo Bonzini
2022-06-24  8:27 ` [PULL 06/14] configure: allow more host/target combos to use the host compiler Paolo Bonzini
2022-06-24  8:27 ` [PULL 07/14] configure: write EXTRA_CFLAGS for all sub-Makefiles Paolo Bonzini
2022-06-24  8:27 ` [PULL 08/14] tests/tcg: compile system emulation tests as freestanding Paolo Bonzini
2022-06-24  8:27 ` [PULL 09/14] build: try both native and cross compilers for linux-user tests Paolo Bonzini
2022-06-24  8:27 ` [PULL 10/14] build: improve -fsanitize-coverage-allowlist check Paolo Bonzini
2022-06-24  8:27 ` [PULL 11/14] fuzz: only use generic-fuzz targets on oss-fuzz Paolo Bonzini
2022-06-24  8:27 ` [PULL 12/14] audio/dbus: fix building Paolo Bonzini
2022-06-24  8:27 ` [PULL 13/14] meson.build: Require a recent version of libpng Paolo Bonzini
2022-06-24  8:27 ` Paolo Bonzini [this message]
2022-06-24 15:57 ` [PULL 00/14] (Mostly) build system changes for 2022-06-24 Richard Henderson
2022-06-30 17:12   ` Paolo Bonzini
2022-06-30 17:32     ` Peter Maydell
2022-07-01  0:26       ` Richard Henderson
2022-07-01  4:11         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624082730.246924-15-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=linmq006@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.