Re: [PATCH 11/36] iio: dac: ds4424: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()

From: Jonathan Cameron <jic23@kernel.org>
To: Ismail Kose <ihkose@gmail.com>
Cc: linux-iio@vger.kernel.org, "Paul Cercueil" <paul@crapouillou.net>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Brian Masney" <masneyb@onstation.org>,
	"David Heidelberg" <david@ixit.cz>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Christian Eggers" <ceggers@arri.de>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Eugen Hristev" <eugen.hristev@microchip.com>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Hui Liu" <hui.liu@mediatek.com>,
	"Joe Sandom" <joe.g.sandom@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Mathieu Othacehe" <m.othacehe@gmail.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Parthiban Nallathambi" <pn@denx.de>,
	"Philippe Reynes" <tremyfr@yahoo.fr>,
	"Philippe Schenker" <philippe.schenker@toradex.com>,
	"Rishi Gupta" <gupt21@gmail.com>,
	"Roan van Dijk" <roan@protonic.nl>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Tomasz Duszynski" <tduszyns@gmail.com>,
	"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 11/36] iio: dac: ds4424: Switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()
Date: Sat, 25 Jun 2022 14:08:55 +0100	[thread overview]
Message-ID: <20220625140855.757b5fcd@jic23-huawei> (raw)
In-Reply-To: <CABEhyf8EezacO8hSCDtz8kDnWeTWFJYBz0XJufjmyprv5u3rmw@mail.gmail.com>

On Thu, 23 Jun 2022 11:04:12 -0700
Ismail Kose <ihkose@gmail.com> wrote:

> signed-off
> ismail.
Hi Ismail,

Thanks for taking a look.

As with the other one, please reply with an
Acked-by tag fully stated as that's what we need to apply it to the patch
(and what automated tooling like b4 will be looking for.

Thanks,

Jonathan

> 
> 
> On Tue, Jun 21, 2022 at 1:19 PM Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Using these newer macros allows the compiler to remove the unused
> > structure and functions when !CONFIG_PM_SLEEP + removes the need to
> > mark pm functions __maybe_unused.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Ismail H. Kose <ihkose@gmail.com>
> > ---
> >  drivers/iio/dac/ds4424.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> > index 5a5e967b0be4..509394690bcc 100644
> > --- a/drivers/iio/dac/ds4424.c
> > +++ b/drivers/iio/dac/ds4424.c
> > @@ -171,7 +171,7 @@ static int ds4424_verify_chip(struct iio_dev
> > *indio_dev)
> >         return ret;
> >  }
> >
> > -static int __maybe_unused ds4424_suspend(struct device *dev)
> > +static int ds4424_suspend(struct device *dev)
> >  {
> >         struct i2c_client *client = to_i2c_client(dev);
> >         struct iio_dev *indio_dev = i2c_get_clientdata(client);
> > @@ -189,7 +189,7 @@ static int __maybe_unused ds4424_suspend(struct device
> > *dev)
> >         return ret;
> >  }
> >
> > -static int __maybe_unused ds4424_resume(struct device *dev)
> > +static int ds4424_resume(struct device *dev)
> >  {
> >         struct i2c_client *client = to_i2c_client(dev);
> >         struct iio_dev *indio_dev = i2c_get_clientdata(client);
> > @@ -206,7 +206,7 @@ static int __maybe_unused ds4424_resume(struct device
> > *dev)
> >         return ret;
> >  }
> >
> > -static SIMPLE_DEV_PM_OPS(ds4424_pm_ops, ds4424_suspend, ds4424_resume);
> > +static DEFINE_SIMPLE_DEV_PM_OPS(ds4424_pm_ops, ds4424_suspend,
> > ds4424_resume);
> >
> >  static const struct iio_info ds4424_info = {
> >         .read_raw = ds4424_read_raw,
> > @@ -312,7 +312,7 @@ static struct i2c_driver ds4424_driver = {
> >         .driver = {
> >                 .name   = "ds4424",
> >                 .of_match_table = ds4424_of_match,
> > -               .pm     = &ds4424_pm_ops,
> > +               .pm     = pm_sleep_ptr(&ds4424_pm_ops),
> >         },
> >         .probe          = ds4424_probe,
> >         .remove         = ds4424_remove,
> > --
> > 2.36.1
> >
> >  