Re: [PATCH V4 09/20] rv/monitor: wip instrumentation and Makefile/Kconfig entries

From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marco Elver <elver@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Gabriele Paoloni <gpaoloni@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Clark Williams <williams@redhat.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V4 09/20] rv/monitor: wip instrumentation and Makefile/Kconfig entries
Date: Tue, 28 Jun 2022 15:02:45 -0400	[thread overview]
Message-ID: <20220628150245.6c59ea52@gandalf.local.home> (raw)
In-Reply-To: <4d975ef5-7e50-9241-1a3e-f0f9bad9c5b5@infradead.org>

On Thu, 16 Jun 2022 14:00:10 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 6/16/22 01:44, Daniel Bristot de Oliveira wrote:
> > diff --git a/kernel/trace/rv/Kconfig b/kernel/trace/rv/Kconfig
> > index 1eafb5adcfcb..e9246b0bec9d 100644
> > --- a/kernel/trace/rv/Kconfig
> > +++ b/kernel/trace/rv/Kconfig
> > @@ -26,6 +26,13 @@ menuconfig RV
> >  	  the system behavior.
> >  
> >  if RV
> > +config RV_MON_WIP
> > +	depends on PREEMPTIRQ_TRACEPOINTS
> > +	select DA_MON_EVENTS_IMPLICIT
> > +	bool "WIP monitor"  
> 
> Does WIP mean work-in-progress?  (It does to me.)
> 
> If not, please explain what it means in the help text.

Yeah, that's exactly what I thought too ;-)

-- Steve

> 
> > +	help
> > +	  Enable WIP sample monitor, this is a sample monitor that
> > +	  illustrates the usage of per-cpu monitors.  
> 
> thanks.