From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Liu Shixin <liushixin2@huawei.com>,
Yang Shi <shy828301@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Muchun Song <songmuchun@bytedance.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [mm-unstable PATCH v4 2/9] mm/hugetlb: separate path for hwpoison entry in copy_hugetlb_page_range()
Date: Mon, 4 Jul 2022 02:04:50 +0000 [thread overview]
Message-ID: <20220704020428.GA2466683@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20220703184259.99a37313037000bd2e9ace9a@linux-foundation.org>
On Sun, Jul 03, 2022 at 06:42:59PM -0700, Andrew Morton wrote:
> On Mon, 4 Jul 2022 10:33:05 +0900 Naoya Horiguchi <naoya.horiguchi@linux.dev> wrote:
>
> > Originally copy_hugetlb_page_range() handles migration entries and hwpoisoned
> > entries in similar manner. But recently the related code path has more code
> > for migration entries, and when is_writable_migration_entry() was converted
> > to !is_readable_migration_entry(), hwpoison entries on source processes got
> > to be unexpectedly updated (which is legitimate for migration entries, but
> > not for hwpoison entries). This results in unexpected serious issues like
> > kernel panic when forking processes with hwpoison entries in pmd.
> >
> > Separate the if branch into one for hwpoison entries and one for migration
> > entries.
> >
> > ...
> >
> > Cc: <stable@vger.kernel.org> # 5.18
>
> It's unusual to have a cc:stable patch in the middle of a series like
> this. One would expect the fix to be a standalone thing against
> current -linus.
Ah, OK, I should've submit this seperately.
>
> As presented, this patch won't get into mainline until after 5.20-rc1.
> If that's OK then OK. Otherwise I can shuffle things around and stage
> this patch in mm-hotfixes?
Yes, I'd like to ask you to do it. Thank you for the arrangement.
- Naoya Horiguchi
next prev parent reply other threads:[~2022-07-04 2:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 1:33 [mm-unstable PATCH v4 0/9] mm, hwpoison: enable 1GB hugepage support (v4) Naoya Horiguchi
2022-07-04 1:33 ` [mm-unstable PATCH v4 1/9] mm/hugetlb: check gigantic_page_runtime_supported() in return_unused_surplus_pages() Naoya Horiguchi
2022-07-05 2:16 ` Miaohe Lin
2022-07-05 6:39 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-06 3:04 ` Miaohe Lin
2022-07-06 3:22 ` Mike Kravetz
2022-07-07 2:59 ` Miaohe Lin
2022-07-06 21:51 ` Mike Kravetz
2022-07-07 0:56 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-04 1:33 ` [mm-unstable PATCH v4 2/9] mm/hugetlb: separate path for hwpoison entry in copy_hugetlb_page_range() Naoya Horiguchi
2022-07-04 1:42 ` Andrew Morton
2022-07-04 2:04 ` HORIGUCHI NAOYA(堀口 直也) [this message]
2022-07-04 1:33 ` [mm-unstable PATCH v4 3/9] mm/hugetlb: make pud_huge() and follow_huge_pud() aware of non-present pud entry Naoya Horiguchi
2022-07-05 2:46 ` Miaohe Lin
2022-07-05 9:04 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-06 3:07 ` Miaohe Lin
2022-07-06 22:21 ` Mike Kravetz
2022-07-04 1:33 ` [mm-unstable PATCH v4 4/9] mm, hwpoison, hugetlb: support saving mechanism of raw error pages Naoya Horiguchi
2022-07-06 2:37 ` Miaohe Lin
2022-07-06 23:06 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-07 3:22 ` Miaohe Lin
2022-07-04 1:33 ` [mm-unstable PATCH v4 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage Naoya Horiguchi
2022-07-06 2:58 ` Miaohe Lin
2022-07-06 23:06 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-07 1:35 ` HORIGUCHI NAOYA(堀口 直也)
2022-07-07 3:08 ` Miaohe Lin
2022-07-04 1:33 ` [mm-unstable PATCH v4 6/9] mm, hwpoison: set PG_hwpoison for busy hugetlb pages Naoya Horiguchi
2022-07-04 1:33 ` [mm-unstable PATCH v4 7/9] mm, hwpoison: make __page_handle_poison returns int Naoya Horiguchi
2022-07-04 1:33 ` [mm-unstable PATCH v4 8/9] mm, hwpoison: skip raw hwpoison page in freeing 1GB hugepage Naoya Horiguchi
2022-07-04 1:33 ` [mm-unstable PATCH v4 9/9] mm, hwpoison: enable memory error handling on " Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704020428.GA2466683@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.