From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, mlxsw@nvidia.com, saeedm@nvidia.com,
moshe@nvidia.com
Subject: [patch net-next repost 3/3] net: devlink: fix return statement in devlink_port_new_notify()
Date: Wed, 13 Jul 2022 16:18:53 +0200 [thread overview]
Message-ID: <20220713141853.2992014-4-jiri@resnulli.us> (raw)
In-Reply-To: <20220713141853.2992014-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@nvidia.com>
Return directly without intermediate value store at the end of
devlink_port_new_notify() function.
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
---
net/core/devlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 2f22ce33c3ec..a9776ea923ae 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1724,8 +1724,7 @@ static int devlink_port_new_notify(struct devlink *devlink,
if (err)
goto out;
- err = genlmsg_reply(msg, info);
- return err;
+ return genlmsg_reply(msg, info);
out:
nlmsg_free(msg);
--
2.35.3
next prev parent reply other threads:[~2022-07-13 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 14:18 [patch net-next repost 0/3] net: devlink: couple of trivial fixes Jiri Pirko
2022-07-13 14:18 ` [patch net-next repost 1/3] net: devlink: make devlink_dpipe_headers_register() return void Jiri Pirko
2022-07-13 14:18 ` [patch net-next repost 2/3] net: devlink: fix a typo in function name devlink_port_new_notifiy() Jiri Pirko
2022-07-13 14:18 ` Jiri Pirko [this message]
2022-07-15 5:20 ` [patch net-next repost 0/3] net: devlink: couple of trivial fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713141853.2992014-4-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.