From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: [PATCH 3/8] ublk: remove the empty open and release block device operations
Date: Thu, 21 Jul 2022 07:16:27 +0200 [thread overview]
Message-ID: <20220721051632.1676890-4-hch@lst.de> (raw)
In-Reply-To: <20220721051632.1676890-1-hch@lst.de>
No need to define empty versions, they can just be left out.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/ublk_drv.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 07913b5bccd90..deabcb23ae2af 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -208,19 +208,8 @@ static inline int ublk_queue_cmd_buf_size(struct ublk_device *ub, int q_id)
PAGE_SIZE);
}
-static int ublk_open(struct block_device *bdev, fmode_t mode)
-{
- return 0;
-}
-
-static void ublk_release(struct gendisk *disk, fmode_t mode)
-{
-}
-
static const struct block_device_operations ub_fops = {
.owner = THIS_MODULE,
- .open = ublk_open,
- .release = ublk_release,
};
#define UBLK_MAX_PIN_PAGES 32
--
2.30.2
next prev parent reply other threads:[~2022-07-21 5:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 5:16 ublk fixups Christoph Hellwig
2022-07-21 5:16 ` [PATCH 1/8] ublk: add a MAINTAINERS entry Christoph Hellwig
2022-07-21 7:11 ` Ming Lei
2022-07-21 5:16 ` [PATCH 2/8] ublk: remove UBLK_IO_F_PREFLUSH Christoph Hellwig
2022-07-21 7:13 ` Ming Lei
2022-07-21 5:16 ` Christoph Hellwig [this message]
2022-07-21 7:13 ` [PATCH 3/8] ublk: remove the empty open and release block device operations Ming Lei
2022-07-21 5:16 ` [PATCH 4/8] ublk: simplify ublk_ch_open and ublk_ch_release Christoph Hellwig
2022-07-21 7:15 ` Ming Lei
2022-07-21 5:16 ` [PATCH 5/8] ublk: cleanup ublk_ctrl_uring_cmd Christoph Hellwig
2022-07-21 7:19 ` Ziyang Zhang
2022-07-21 12:12 ` Ming Lei
2022-07-21 5:16 ` [PATCH 6/8] ublk: fold __ublk_create_dev into ublk_ctrl_add_dev Christoph Hellwig
2022-07-21 7:33 ` Ziyang Zhang
2022-07-21 7:35 ` Ming Lei
2022-07-21 5:16 ` [PATCH 7/8] ublk: rewrite ublk_ctrl_get_queue_affinity to not rely on hctx->cpumask Christoph Hellwig
2022-07-21 7:38 ` Ming Lei
2022-07-21 5:16 ` [PATCH 8/8] ublk: defer disk allocation Christoph Hellwig
2022-07-21 7:55 ` Ming Lei
2022-07-21 13:09 ublk fixups v2 Christoph Hellwig
2022-07-21 13:09 ` [PATCH 3/8] ublk: remove the empty open and release block device operations Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721051632.1676890-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.