From: Steffen Klassert <steffen.klassert@secunet.com>
To: Antony Antony <antony.antony@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
<0002-xfrm-fix-XFRMA_LASTUSED-comment.patch@moon.secunet.de>,
<0003-xfrm-clone-missing-x-lastused-in-xfrm_do_migrate.patch@moon.secunet.de>,
<netdev@vger.kernel.org>, Tobias Brunner <tobias@strongswan.org>
Subject: Re: [PATCH ipsec 1/3] Revert "xfrm: update SA curlft.use_time"
Date: Thu, 4 Aug 2022 11:31:14 +0200 [thread overview]
Message-ID: <20220804093114.GS2950045@gauss3.secunet.de> (raw)
In-Reply-To: <e66a68873492c0b3e02f8459e88cedabe255e3b6.1658936270.git.antony.antony@secunet.com>
On Wed, Jul 27, 2022 at 05:38:35PM +0200, Antony Antony wrote:
> This reverts commit af734a26a1a95a9fda51f2abb0c22a7efcafd5ca.
>
> The abvoce commit is a regression according RFC 2367. A better fix would be
> use x->lastused. Which will be propsed later.
>
> according to RFC 2367 use_time == sadb_lifetime_usetime.
>
> "sadb_lifetime_usetime
> For CURRENT, the time, in seconds, when association
> was first used. For HARD and SOFT, the number of
> seconds after the first use of the association until
> it expires."
>
> Fixes: af734a26a1a9 ("xfrm: update SA curlft.use_time")
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
Series applied, thanks Antony!
next prev parent reply other threads:[~2022-08-04 9:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 6:16 [PATCH ipsec-next 1/4] Revert "xfrm: update SA curlft.use_time" Antony Antony
2022-07-08 6:16 ` [PATCH ipsec-next 2/4] xfrm: fix XFRMA_LASTUSED comment Antony Antony
2022-07-08 6:17 ` [PATCH ipsec-next 3/4] xfrm: update x->lastused for every packet Antony Antony
2022-07-08 6:18 ` [PATCH ipsec-next 4/4] xfrm: clone x->lastused in xfrm_do_migrate Antony Antony
2022-07-11 8:34 ` Steffen Klassert
2022-07-11 8:24 ` [PATCH ipsec-next 1/4] Revert "xfrm: update SA curlft.use_time" Steffen Klassert
2022-07-27 15:38 ` [PATCH ipsec 1/3] " Antony Antony
2022-07-27 15:45 ` Antony Antony
2022-08-04 9:31 ` Steffen Klassert [this message]
2022-07-27 15:40 ` [PATCH ipsec 2/3] xfrm: fix XFRMA_LASTUSED comment Antony Antony
2022-07-27 15:41 ` [PATCH ipsec 3/3] xfrm: clone missing x->lastused in xfrm_do_migrate Antony Antony
2022-10-21 13:42 ` [PATCH ipsec-next v2] xfrm: update x->lastused for every packet Antony Antony
2022-10-28 11:35 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804093114.GS2950045@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=0002-xfrm-fix-XFRMA_LASTUSED-comment.patch@moon.secunet.de \
--cc=0003-xfrm-clone-missing-x-lastused-in-xfrm_do_migrate.patch@moon.secunet.de \
--cc=antony.antony@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.