All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: linux-fsdevel@vger.kernel.org
Cc: dhowells@redhat.com, lczerner@redhat.com, bxue@redhat.com,
	ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [RFC PATCH 2/4] nfs: report the change attribute if requested
Date: Fri,  5 Aug 2022 14:35:41 -0400	[thread overview]
Message-ID: <20220805183543.274352-3-jlayton@kernel.org> (raw)
In-Reply-To: <20220805183543.274352-1-jlayton@kernel.org>

Allow NFS to report the i_version in statx. Since the cost to fetch it
is relatively cheap, do it unconditionally and just set the flag if it
looks like it's valid.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/nfs/inode.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index b4e46b0ffa2d..8e0e7ecf6429 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -829,6 +829,8 @@ static u32 nfs_get_valid_attrmask(struct inode *inode)
 		reply_mask |= STATX_UID | STATX_GID;
 	if (!(cache_validity & NFS_INO_INVALID_BLOCKS))
 		reply_mask |= STATX_BLOCKS;
+	if (!(cache_validity & NFS_INO_INVALID_CHANGE))
+		reply_mask |= STATX_CHGATTR;
 	return reply_mask;
 }
 
@@ -914,6 +916,7 @@ int nfs_getattr(struct user_namespace *mnt_userns, const struct path *path,
 
 	generic_fillattr(&init_user_ns, inode, stat);
 	stat->ino = nfs_compat_user_ino64(NFS_FILEID(inode));
+	stat->chgattr = inode_peek_iversion_raw(inode);
 	if (S_ISDIR(inode->i_mode))
 		stat->blksize = NFS_SERVER(inode)->dtsize;
 out:
-- 
2.37.1


  parent reply	other threads:[~2022-08-05 18:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 18:35 [RFC PATCH 0/4] vfs: allow querying i_version via statx Jeff Layton
2022-08-05 18:35 ` [RFC PATCH 1/4] vfs: report change attribute in statx for IS_I_VERSION inodes Jeff Layton
2022-08-05 22:01   ` Dave Chinner
2022-08-05 22:06     ` Jeff Layton
2022-08-08 13:19       ` Jeff Layton
2022-08-09 15:33         ` Darrick J. Wong
2022-08-09 18:04           ` Jeff Layton
2022-08-09 18:28             ` Jeff Layton
2022-08-08  2:09   ` Xiubo Li
2022-08-08 10:18     ` Jeff Layton
2022-08-10  3:00   ` JunChao Sun
2022-08-10 10:35     ` Jeff Layton
2022-08-05 18:35 ` Jeff Layton [this message]
2022-08-05 18:35 ` [RFC PATCH 3/4] afs: fill out change attribute in statx replies Jeff Layton
2022-08-05 18:35 ` [RFC PATCH 4/4] ceph: fill in the change attribute in statx requests Jeff Layton
2022-08-08 11:56   ` Xiubo Li
2022-08-05 18:52 ` [RFC PATCH 0/4] vfs: allow querying i_version via statx Frank Filz
2022-08-05 19:17 ` [RFC PATCH 1/4] vfs: report change attribute in statx for IS_I_VERSION inodes David Howells
2022-08-05 20:00   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805183543.274352-3-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=bxue@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dhowells@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.