Re: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto

From: Andres Freund <andres@anarazel.de>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	quentin@isovalent.com, ast@kernel.org, andrii@kernel.org,
	martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com,
	kpsingh@kernel.org, sdf@google.com, peterz@infradead.org,
	mingo@redhat.com, terrelln@fb.com, nathan@kernel.org,
	ndesaulniers@google.com, bpf@vger.kernel.org,
	linux-perf-users@vger.kernel.org, llvm@lists.linux.dev,
	linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto
Date: Tue, 9 Aug 2022 10:00:34 -0700	[thread overview]
Message-ID: <20220809170034.hx7fyiosm3tfekwf@awork3.anarazel.de> (raw)
In-Reply-To: <YvJ7awkCVBYaZ2dd@kernel.org>

Hi,

On 2022-08-09 12:21:15 -0300, Arnaldo Carvalho de Melo wrote:
> So I backtracked, the way it works needs further consideration with
> regard to the patchkit from Andres, that is already upstream, so it
> would be good for Roberto to take a look at what is in torvalds/master
> now and see if we have to removed that styled thing from Andres.

Why would it have to be removed - seems to be fairly independent, leaving the
line conflicts aside? Or do you just mean folding it into one-big-test? If so,
that'd make sense, although I'm not sure how ready the infrastructure

FWIW, if I would have to maintain these, I'd probably change FEATURE_TESTS,
FEATURE_DISPLAY into one-item-per-line to make conflicts less common and
easier to resolve.

> Andres, if you could take a look at Roberto's patchkit as well that
> would be great.

I briefly scanned it, and the only real comment I have mirror's Quentin's,
namely that it'd be nice to avoid displaying more tests that don't tell the
user much.

Greetings,

Andres Freund