Re: [Intel-gfx] [Intel-gfx 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

From: kernel test robot <lkp@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [Intel-gfx 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero
Date: Mon, 15 Aug 2022 08:51:44 +0800	[thread overview]
Message-ID: <202208150850.JJ4hGJX2-lkp@intel.com> (raw)
In-Reply-To: <20220814224331.1427330-3-alan.previn.teres.alexis@intel.com>

Hi Alan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 1cb5379e17f93685065d8ec54444f1baf9386ffe]

url:    https://github.com/intel-lab-lkp/linux/commits/Alan-Previn/Delay-disabling-scheduling-on-a-context/20220815-064329
base:   1cb5379e17f93685065d8ec54444f1baf9386ffe
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220815/202208150850.JJ4hGJX2-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/521d8255b73015ef55e0466508f9f9accf64aba6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Alan-Previn/Delay-disabling-scheduling-on-a-context/20220815-064329
        git checkout 521d8255b73015ef55e0466508f9f9accf64aba6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4292:5: warning: no previous prototype for function '__guc_get_non_lrc_num_guc_ids' [-Wmissing-prototypes]
   int __guc_get_non_lrc_num_guc_ids(struct intel_guc *guc)
       ^
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4292:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __guc_get_non_lrc_num_guc_ids(struct intel_guc *guc)
   ^
   static 
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4297:5: warning: no previous prototype for function '__guc_get_sched_disable_gucid_threshold_default' [-Wmissing-prototypes]
   int __guc_get_sched_disable_gucid_threshold_default(struct intel_guc *guc)
       ^
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:4297:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __guc_get_sched_disable_gucid_threshold_default(struct intel_guc *guc)
   ^
   static 
   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:353:20: warning: unused function 'context_has_committed_requests' [-Wunused-function]
   static inline bool context_has_committed_requests(struct intel_context *ce)
                      ^
   3 warnings generated.

vim +/__guc_get_non_lrc_num_guc_ids +4292 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

  4291	
> 4292	int __guc_get_non_lrc_num_guc_ids(struct intel_guc *guc)
  4293	{
  4294		return guc->submission_state.num_guc_ids - NUMBER_MULTI_LRC_GUC_ID(guc);
  4295	}
  4296	
> 4297	int __guc_get_sched_disable_gucid_threshold_default(struct intel_guc *guc)
  4298	{
  4299		return (__guc_get_non_lrc_num_guc_ids(guc) / 4 * 3);
  4300	}
  4301	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp