All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: linux-clk@vger.kernel.org,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v8 06/25] clk: tests: Add test suites description
Date: Mon, 15 Aug 2022 17:41:28 +0200	[thread overview]
Message-ID: <20220815154147.1631441-7-maxime@cerno.tech> (raw)
In-Reply-To: <20220815154147.1631441-1-maxime@cerno.tech>

We start to have a few test suites, and we'll add more, so it will get
pretty confusing to figure out what is supposed to be tested in what
suite.

Let's add some comments to explain what setup they create, and what we
should be testing in every suite.

Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> # imx8mp
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> # exynos4210, meson g12b
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/clk/clk_test.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c
index 7d9da88c39ee..1a7cb482ec58 100644
--- a/drivers/clk/clk_test.c
+++ b/drivers/clk/clk_test.c
@@ -258,6 +258,11 @@ static struct kunit_case clk_test_cases[] = {
 	{}
 };
 
+/*
+ * Test suite for a basic rate clock, without any parent.
+ *
+ * These tests exercise the rate API with simple scenarios
+ */
 static struct kunit_suite clk_test_suite = {
 	.name = "clk-test",
 	.init = clk_test_init,
@@ -346,6 +351,14 @@ static struct kunit_case clk_orphan_transparent_single_parent_mux_test_cases[] =
 	{}
 };
 
+/*
+ * Test suite for a basic mux clock with one parent. The parent is
+ * registered after its child. The clock will thus be an orphan when
+ * registered, but will no longer be when the tests run.
+ *
+ * These tests make sure a clock that used to be orphan has a sane,
+ * consistent, behaviour.
+ */
 static struct kunit_suite clk_orphan_transparent_single_parent_test_suite = {
 	.name = "clk-orphan-transparent-single-parent-test",
 	.init = clk_orphan_transparent_single_parent_mux_test_init,
@@ -675,6 +688,12 @@ static struct kunit_case clk_range_test_cases[] = {
 	{}
 };
 
+/*
+ * Test suite for a basic rate clock, without any parent.
+ *
+ * These tests exercise the rate range API: clk_set_rate_range(),
+ * clk_set_min_rate(), clk_set_max_rate(), clk_drop_range().
+ */
 static struct kunit_suite clk_range_test_suite = {
 	.name = "clk-range-test",
 	.init = clk_test_init,
@@ -856,6 +875,13 @@ static struct kunit_case clk_range_maximize_test_cases[] = {
 	{}
 };
 
+/*
+ * Test suite for a basic rate clock, without any parent.
+ *
+ * These tests exercise the rate range API: clk_set_rate_range(),
+ * clk_set_min_rate(), clk_set_max_rate(), clk_drop_range(), with a
+ * driver that will always try to run at the highest possible rate.
+ */
 static struct kunit_suite clk_range_maximize_test_suite = {
 	.name = "clk-range-maximize-test",
 	.init = clk_maximize_test_init,
@@ -1029,6 +1055,13 @@ static struct kunit_case clk_range_minimize_test_cases[] = {
 	{}
 };
 
+/*
+ * Test suite for a basic rate clock, without any parent.
+ *
+ * These tests exercise the rate range API: clk_set_rate_range(),
+ * clk_set_min_rate(), clk_set_max_rate(), clk_drop_range(), with a
+ * driver that will always try to run at the lowest possible rate.
+ */
 static struct kunit_suite clk_range_minimize_test_suite = {
 	.name = "clk-range-minimize-test",
 	.init = clk_minimize_test_init,
-- 
2.37.1


  parent reply	other threads:[~2022-08-15 15:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 15:41 [PATCH v8 00/25] clk: More clock rate fixes and tests Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 01/25] clk: test: Switch to clk_hw_get_clk Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 02/25] clk: Drop the rate range on clk_put() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 03/25] clk: Skip clamping when rounding if there's no boundaries Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 04/25] clk: Mention that .recalc_rate can return 0 on error Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 05/25] clk: Clarify clk_get_rate() expectations Maxime Ripard
2022-08-15 15:41 ` Maxime Ripard [this message]
2022-08-15 15:41 ` [PATCH v8 07/25] clk: tests: Add reference to the orphan mux bug report Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 08/25] clk: tests: Add tests for uncached clock Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 09/25] clk: tests: Add tests for single parent mux Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 10/25] clk: tests: Add tests for mux with multiple parents Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 11/25] clk: tests: Add some tests for orphan " Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 12/25] clk: Take into account uncached clocks in clk_set_rate_range() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 13/25] clk: Set req_rate on reparenting Maxime Ripard
2022-08-16  8:30   ` Alexander Stein
2022-08-16  9:24     ` Maxime Ripard
2022-08-16  9:57       ` Alexander Stein
2022-08-16 11:14         ` Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 14/25] clk: Change clk_core_init_rate_req prototype Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 15/25] clk: Move clk_core_init_rate_req() from clk_core_round_rate_nolock() to its caller Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 16/25] clk: Introduce clk_hw_init_rate_request() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 17/25] clk: Add our request boundaries in clk_core_init_rate_req Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 18/25] clk: Switch from __clk_determine_rate to clk_core_round_rate_nolock Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 19/25] clk: Introduce clk_core_has_parent() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 20/25] clk: Constify clk_has_parent() Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 21/25] clk: Stop forwarding clk_rate_requests to the parent Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 22/25] clk: Zero the clk_rate_request structure Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 23/25] clk: Introduce the clk_hw_get_rate_range function Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 24/25] clk: qcom: clk-rcg2: Take clock boundaries into consideration for gfx3d Maxime Ripard
2022-08-15 15:41 ` [PATCH v8 25/25] clk: tests: Add missing test case for ranges Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220815154147.1631441-7-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.