From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
amadeuszx.slawinski@linux.intel.com
Subject: [RESEND PATCH v2 0/6] ALSA: hda: Unify codec construction
Date: Tue, 16 Aug 2022 13:17:21 +0200 [thread overview]
Message-ID: <20220816111727.3218543-1-cezary.rojewski@intel.com> (raw)
A follow up to the recent HDAudio fixes series [1]. Given the recently
reported regression [2], before the page fault occurring on codec
shutdown can be fixed, codec construction procedure needs to be updated
for skylake and sof-intel drivers. Drivers: pci-hda and avs need no
changes - already making use of snd_hda_codec_device_init().
As subject touches code used by the sof-driver, additional review has
been conducted on thesofproject/linux [3].
Changes in v2:
- dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling
snd_hda_codec_device_init() directly in skylake and sof drivers probe
enumeration routines, as suggested by Takashi
- skylake/sof portion of the change has been split into two separate
patches
- new functions that aim to replace hdac_ext codec init & exit
functionality are added first - for skylake and sof drivers both
- third patch in the series now combines the "field -> pointer" change
for hdac_hda_priv->codec plus the codec-enumeration adjustments for
skylake and sof drivers
Both above are here to keep git bisect happy, as suggested by Pierre
[1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@intel.com/
[2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@linux.intel.com/
[3]: https://github.com/thesofproject/linux/pull/3775
Cezary Rojewski (6):
ASoC: Intel: Skylake: Introduce HDA codec init and exit routines
ASoC: SOF: Intel: Introduce HDA codec init and exit routines
ASoC: Intel: Drop hdac_ext usage for codec device creation
ALSA: hda: Always free codec on the device release
ALSA: hda: Remove codec init and exit routines
ALSA: hda: Fix page fault in snd_hda_codec_shutdown()
include/sound/hda_codec.h | 2 -
include/sound/hdaudio_ext.h | 3 --
sound/hda/ext/hdac_ext_bus.c | 53 -------------------
sound/pci/hda/hda_codec.c | 49 ++++++++---------
sound/soc/codecs/hdac_hda.c | 26 ++++-----
sound/soc/codecs/hdac_hda.h | 2 +-
sound/soc/intel/boards/hda_dsp_common.c | 2 +-
sound/soc/intel/boards/skl_hda_dsp_generic.c | 2 +-
sound/soc/intel/skylake/skl.c | 53 ++++++++++++++-----
sound/soc/sof/intel/hda-codec.c | 55 ++++++++++++++------
10 files changed, 113 insertions(+), 134 deletions(-)
--
2.25.1
next reply other threads:[~2022-08-16 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 11:17 Cezary Rojewski [this message]
2022-08-16 11:17 ` [RESEND PATCH v2 1/6] ASoC: Intel: Skylake: Introduce HDA codec init and exit routines Cezary Rojewski
2022-08-16 11:23 ` Mark Brown
2022-08-16 11:17 ` [RESEND PATCH v2 2/6] ASoC: SOF: Intel: " Cezary Rojewski
2022-08-16 11:17 ` [RESEND PATCH v2 3/6] ASoC: Intel: Drop hdac_ext usage for codec device creation Cezary Rojewski
2022-08-16 11:17 ` [RESEND PATCH v2 4/6] ALSA: hda: Always free codec on the device release Cezary Rojewski
2022-08-16 11:17 ` [RESEND PATCH v2 5/6] ALSA: hda: Remove codec init and exit routines Cezary Rojewski
2022-08-16 11:17 ` [RESEND PATCH v2 6/6] ALSA: hda: Fix page fault in snd_hda_codec_shutdown() Cezary Rojewski
2022-08-16 11:30 ` [RESEND PATCH v2 0/6] ALSA: hda: Unify codec construction Cezary Rojewski
2022-08-18 7:52 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816111727.3218543-1-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.