From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/3] dev: Move received_rps counter next to RPS members in softnet data
Date: Fri, 19 Aug 2022 15:54:21 -0700 [thread overview]
Message-ID: <20220819155421.3ca7d6d6@kernel.org> (raw)
In-Reply-To: <87bksgv26h.fsf@toke.dk>
On Fri, 19 Aug 2022 14:38:14 +0200 Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> > On Thu, 18 Aug 2022 18:59:03 +0200 Toke Høiland-Jørgensen wrote:
> >> Move the received_rps counter value next to the other RPS-related members
> >> in softnet_data. This closes two four-byte holes in the structure, making
> >> room for another pointer in the first two cache lines without bumping the
> >> xmit struct to its own line.
> >
> > What's the pointer you're making space for (which I hope will explain
> > why this patch is part of this otherwise bpf series)?
>
> The XDP queueing series adds a pointer to keep track of which interfaces
> were scheduled for transmission using the XDP dequeue hook (similar to
> how the qdisc wake code works):
>
> https://lore.kernel.org/r/20220713111430.134810-12-toke@redhat.com
I see, it makes more sense now :)
> Note that it's still up in the air if this ends up being the way this
> will be implemented, so I'm OK with dropping this patch for now if you'd
> rather wait until it's really needed. OTOH it also seemed like a benign
> change on its own, so I figured I might as well include this patch when
> sending these out. WDYT?
Whatever is easiest :)
next prev parent reply other threads:[~2022-08-19 22:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 16:59 [PATCH bpf-next 0/3] A couple of small refactorings of BPF program call sites Toke Høiland-Jørgensen
2022-08-18 16:59 ` [PATCH bpf-next 1/3] dev: Move received_rps counter next to RPS members in softnet data Toke Høiland-Jørgensen
2022-08-19 3:01 ` Jakub Kicinski
2022-08-19 12:38 ` Toke Høiland-Jørgensen
2022-08-19 22:54 ` Jakub Kicinski [this message]
2022-08-22 10:17 ` Toke Høiland-Jørgensen
2022-08-18 16:59 ` [PATCH bpf-next 2/3] bpf: Expand map key argument of bpf_redirect_map to u64 Toke Høiland-Jørgensen
2022-08-18 16:59 ` [PATCH bpf-next 3/3] bpf: Use 64-bit return value for bpf_prog_run Toke Høiland-Jørgensen
2022-08-18 22:26 ` [PATCH bpf-next 0/3] A couple of small refactorings of BPF program call sites sdf
2022-08-19 5:24 ` Kumar Kartikeya Dwivedi
2022-08-23 22:29 ` Daniel Borkmann
2022-08-25 13:15 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819155421.3ca7d6d6@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.