From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 00/31] btrfs: move extent_io_tree code and cleanups
Date: Tue, 6 Sep 2022 20:30:37 +0200 [thread overview]
Message-ID: <20220906183037.GU13489@twin.jikos.cz> (raw)
In-Reply-To: <cover.1662149276.git.josef@toxicpanda.com>
On Fri, Sep 02, 2022 at 04:16:05PM -0400, Josef Bacik wrote:
> In working on extent tree v2 I got really bogged down in trying to sync work
> between btrfs-progs and the kernel. It basically takes me 3x as long, because
> there's a lot of different things missing in btrfs-progs, so each patchset has
> to be done from scratch and tested completely differently.
>
> Additionally there's just a lot of tech-debt in these areas in general. So
> before tackling the rest of extent-tree-v2 I'm spending some time cleaning up
> things we all know are terrible. This is the first step in that direction,
> finishing the separation of the extent_io_tree code from extent_io.c. I started
> this a while ago, but got bogged down in other things.
>
> This has 3 distinct parts
>
> 1. Cleanup the io_failure_record code. This has been tightly integrated into
> the extent_io_tree code forever without much reason for it. The first part
> of this series moves that handling into it's own tree, and uses our existing
> helpers to reduce the code quite a bit.
>
> 2. Move the code out of extent_io.c. This is easier than previous code moves
> because I did a lot of the prep work earlier. Unfortunately there is one big
> patch that copy and pastes all the core code, since it all depends on itself
> and would be more annoying to move. However the independent parts were
> moved piece by piece.
>
> 3. A wholesale cleanup of the extent_io_tree code. We have a ton of helpers
> here, that have all grown a ton of arguments over the years. I've trimmed
> down the arguments for our core helpers, and hidden the rest internally
> inside of extent-io-tree.c. Additionally I've cleaned up the lock/unlock
> extent bit helpers so we only have one lock_extent/unlock_extent variant that
> gets used everywhere.
>
> I've tested this locally to make sure I didn't break anything. This isn't a
> simple code move so do please review most of it, the patches that start with
> "move X" are pure code move patches, but the rest do change things. Thanks,
As this is mostly simple cleanups or straightfowrad changes I think it's
safe to merge before code freeze. I'll send more comments to the
patches, there are some minor issues or missing commit references to
last code that used some structure when it's removed.
As others noted this patchset conflicts with the series from Christoph,
namely the io_failure_tree removal, but that series is more intrusive
and with pending reviews.
next prev parent reply other threads:[~2022-09-06 18:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 20:16 [PATCH 00/31] btrfs: move extent_io_tree code and cleanups Josef Bacik
2022-09-02 20:16 ` [PATCH 01/31] btrfs: cleanup clean_io_failure Josef Bacik
2022-09-05 12:27 ` Johannes Thumshirn
2022-09-07 18:51 ` David Sterba
2022-09-02 20:16 ` [PATCH 02/31] btrfs: unexport internal failrec functions Josef Bacik
2022-09-02 20:16 ` [PATCH 03/31] btrfs: stop using extent_io_tree for io_failure_record's Josef Bacik
2022-09-07 18:53 ` David Sterba
2022-09-02 20:16 ` [PATCH 04/31] btrfs: use find_first_extent_bit in btrfs_clean_io_failure Josef Bacik
2022-09-02 20:16 ` [PATCH 05/31] btrfs: separate out the extent state and extent buffer init code Josef Bacik
2022-09-02 20:16 ` [PATCH 06/31] btrfs: separate out the eb and extent state leak helpers Josef Bacik
2022-09-02 20:16 ` [PATCH 07/31] btrfs: temporarily export alloc_extent_state helpers Josef Bacik
2022-09-02 20:16 ` [PATCH 08/31] btrfs: move extent state init and alloc functions to their own file Josef Bacik
2022-09-02 20:16 ` [PATCH 09/31] btrfs: convert BUG_ON(EXTENT_BIT_LOCKED) checks to ASSERT's Josef Bacik
2022-09-07 18:57 ` David Sterba
2022-09-02 20:16 ` [PATCH 10/31] btrfs: move simple extent bit helpers out of extent_io.c Josef Bacik
2022-09-02 20:16 ` [PATCH 11/31] btrfs: export wait_extent_bit Josef Bacik
2022-09-02 20:16 ` [PATCH 12/31] btrfs: move the core extent_io_tree code into extent-io-tree.c Josef Bacik
2022-09-03 6:28 ` kernel test robot
2022-09-07 19:03 ` David Sterba
2022-09-02 20:16 ` [PATCH 13/31] btrfs: remove struct tree_entry Josef Bacik
2022-09-02 20:16 ` [PATCH 14/31] btrfs: use next_state instead of rb_next where we can Josef Bacik
2022-09-02 20:16 ` [PATCH 15/31] btrfs: make tree_search return struct extent_state Josef Bacik
2022-09-02 20:16 ` [PATCH 16/31] btrfs: make tree_search_for_insert return extent_state Josef Bacik
2022-09-02 20:16 ` [PATCH 17/31] btrfs: make tree_search_prev_next return extent_state's Josef Bacik
2022-09-02 20:16 ` [PATCH 18/31] btrfs: use next_state/prev_state in merge_state Josef Bacik
2022-09-02 20:16 ` [PATCH 19/31] btrfs: remove temporary exports for extent_state movement Josef Bacik
2022-09-02 20:16 ` [PATCH 20/31] btrfs: move irrelevant prototypes to their appropriate header Josef Bacik
2022-09-02 20:16 ` [PATCH 21/31] btrfs: drop exclusive_bits from set_extent_bit Josef Bacik
2022-09-02 20:16 ` [PATCH 22/31] btrfs: remove the wake argument from clear_extent_bits Josef Bacik
2022-09-02 20:16 ` [PATCH 23/31] btrfs: remove failed_start argument from set_extent_bit Josef Bacik
2022-09-02 20:16 ` [PATCH 24/31] btrfs: drop extent_changeset " Josef Bacik
2022-09-02 20:16 ` [PATCH 25/31] btrfs: unify the lock/unlock extent variants Josef Bacik
2022-09-02 20:16 ` [PATCH 26/31] btrfs: get rid of track_uptodate Josef Bacik
2022-09-07 18:47 ` David Sterba
2022-09-02 20:16 ` [PATCH 27/31] btrfs: get rid of ->dirty_bytes Josef Bacik
2022-09-07 18:48 ` David Sterba
2022-09-02 20:16 ` [PATCH 28/31] btrfs: don't clear CTL bits when trying to release extent state Josef Bacik
2022-09-02 20:16 ` [PATCH 29/31] btrfs: replace delete argument with EXTENT_CLEAR_ALL_BITS Josef Bacik
2022-09-02 20:16 ` [PATCH 30/31] btrfs: don't init io tree with private data for non inodes Josef Bacik
2022-09-02 20:16 ` [PATCH 31/31] btrfs: remove is_data_inode() checks in extent-io-tree.c Josef Bacik
2022-09-06 18:30 ` David Sterba [this message]
2022-09-07 18:42 ` [PATCH 00/31] btrfs: move extent_io_tree code and cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906183037.GU13489@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.