From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Denys Zagorui <dzagorui@cisco.com>,
Meng.Li@windriver.com, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: ltc2497: Fix reading conversion results
Date: Mon, 12 Sep 2022 12:46:31 +0200 [thread overview]
Message-ID: <20220912104631.zysrv2qqxvsjfbxc@pengutronix.de> (raw)
In-Reply-To: <20220820130648.5b9bc66f@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote:
> On Mon, 15 Aug 2022 09:16:47 +0000
> Denys Zagorui <dzagorui@cisco.com> wrote:
>
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > After the result of the previous conversion is read the chip
> > automatically starts a new conversion and doesn't accept new i2c
> > transfers until this conversion is completed which makes the function
> > return failure.
>
> That's rather nasty.
>
> Could we add a cheeky sleep in the other path to ensure there is always
> time for the conversion to be done? Not ideal, but might ensure
> there isn't a known problem path without introducing much complexity.
FTR: While the patch was originally authored by me, I don't currently
have access to a machine with that chip. So currently there will be no
incentive on my side to address this feedback.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-12 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 9:16 [PATCH] iio: ltc2497: Fix reading conversion results Denys Zagorui
2022-08-20 12:06 ` Jonathan Cameron
2022-09-12 10:46 ` Uwe Kleine-König [this message]
2022-09-18 14:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912104631.zysrv2qqxvsjfbxc@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Meng.Li@windriver.com \
--cc=Michael.Hennerich@analog.com \
--cc=dzagorui@cisco.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.