From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Suren Baghdasaryan <surenb@google.com>,
<linux-kernel@vger.kernel.org>
Cc: <quic_charante@quicinc.com>
Subject: PSI idle-shutoff
Date: Tue, 13 Sep 2022 19:38:17 +0530 [thread overview]
Message-ID: <20220913140817.GA9091@hu-pkondeti-hyd.qualcomm.com> (raw)
Hi
The fact that psi_avgs_work()->collect_percpu_times()->get_recent_times()
run from a kworker thread, PSI_NONIDLE condition would be observed as
there is a RUNNING task. So we would always end up re-arming the work.
If the work is re-armed from the psi_avgs_work() it self, the backing off
logic in psi_task_change() (will be moved to psi_task_switch soon) can't
help. The work is already scheduled. so we don't do anything there.
Probably I am missing some thing here. Can you please clarify how we
shut off re-arming the psi avg work?
Thanks,
Pavan
next reply other threads:[~2022-09-13 14:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 14:08 Pavan Kondeti [this message]
2022-09-15 6:20 ` PSI idle-shutoff Pavan Kondeti
2022-09-17 5:45 ` Suren Baghdasaryan
2022-10-03 6:11 ` Suren Baghdasaryan
2022-10-05 16:32 ` Suren Baghdasaryan
2022-10-09 12:41 ` Chengming Zhou
2022-10-09 13:17 ` Chengming Zhou
2022-10-10 6:18 ` Pavan Kondeti
2022-10-10 6:43 ` Pavan Kondeti
2022-10-10 6:57 ` [External] " Chengming Zhou
2022-10-10 8:30 ` Chengming Zhou
2022-10-10 9:09 ` Pavan Kondeti
2022-10-10 9:22 ` Chengming Zhou
2022-10-10 20:59 ` Suren Baghdasaryan
2022-10-10 20:33 ` Suren Baghdasaryan
2022-10-10 5:57 ` Pavan Kondeti
2022-10-10 9:01 ` Pavan Kondeti
2022-10-10 6:25 ` Pavan Kondeti
2022-10-10 10:42 ` [PATCH] sched/psi: Fix avgs_work re-arm in psi_avgs_work() Chengming Zhou
2022-10-10 21:21 ` Suren Baghdasaryan
2022-10-11 0:07 ` Chengming Zhou
2022-10-11 17:00 ` Suren Baghdasaryan
2022-10-12 2:10 ` Chengming Zhou
2022-10-12 18:24 ` Suren Baghdasaryan
2022-10-13 2:23 ` Chengming Zhou
2022-10-13 11:06 ` Chengming Zhou
2022-10-13 15:52 ` Johannes Weiner
2022-10-13 16:10 ` Suren Baghdasaryan
2022-10-14 2:03 ` Chengming Zhou
2022-10-14 2:02 ` Chengming Zhou
2022-10-28 6:42 ` [tip: sched/core] " tip-bot2 for Chengming Zhou
2022-10-28 6:50 ` [External] " Chengming Zhou
2022-10-28 15:58 ` Suren Baghdasaryan
2022-10-28 16:05 ` Chengming Zhou
2022-10-28 19:53 ` [External] " Peter Zijlstra
2022-10-29 11:55 ` Peter Zijlstra
2022-10-29 12:40 ` Chengming Zhou
2022-10-29 18:46 ` Suren Baghdasaryan
2022-10-10 10:57 ` PSI idle-shutoff Hillf Danton
2022-10-10 21:16 ` Suren Baghdasaryan
2022-10-11 11:38 ` Hillf Danton
2022-10-11 17:11 ` Suren Baghdasaryan
2022-10-12 6:20 ` Hillf Danton
2022-10-12 15:40 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913140817.GA9091@hu-pkondeti-hyd.qualcomm.com \
--to=quic_pkondeti@quicinc.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_charante@quicinc.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.