From: Christian Eggers <ceggers@arri.de>
To: <linux-bluetooth@vger.kernel.org>
Cc: Christian Eggers <ceggers@arri.de>
Subject: [PATCH BlueZ 1/9] advertising: parse_secondary: fix loop condition
Date: Fri, 23 Sep 2022 12:24:13 +0200 [thread overview]
Message-ID: <20220923102421.10336-2-ceggers@arri.de> (raw)
In-Reply-To: <20220923102421.10336-1-ceggers@arri.de>
"secondary" isn't an array of pointers, so the iterator can never be
NULL.
---
src/advertising.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/advertising.c b/src/advertising.c
index 1fe371a9f345..15ef44def031 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -1055,7 +1055,7 @@ static bool parse_secondary(DBusMessageIter *iter,
dbus_message_iter_get_basic(iter, &str);
- for (sec = secondary; sec && sec->name; sec++) {
+ for (sec = secondary; sec->name; sec++) {
if (strcmp(str, sec->name))
continue;
--
2.35.3
next prev parent reply other threads:[~2022-09-23 10:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:24 [PATCH BlueZ 0/9] properties_changed: check for NULL iterator Christian Eggers
2022-09-23 10:24 ` Christian Eggers [this message]
2022-09-23 11:21 ` bluez.test.bot
2022-09-23 10:24 ` [PATCH BlueZ 2/9] advertising: parse_secondary: fix mask value Christian Eggers
2022-09-23 10:24 ` [PATCH BlueZ 3/9] advertising: parse_secondary: check for NULL iterator Christian Eggers
2022-09-23 10:24 ` [PATCH BlueZ 4/9] advertising: parse_min_interval: reset min_interval if iter is NULL Christian Eggers
2022-09-23 10:26 ` Christian Eggers
2022-09-23 20:50 ` patchwork-bot+bluetooth
2022-09-23 10:26 ` [PATCH BlueZ 5/9] advertising: parse_[min|max]_interval: reset value " Christian Eggers
2022-09-23 10:26 ` [PATCH BlueZ 6/9] advertising: parse_tx_power: " Christian Eggers
2022-09-23 10:26 ` [PATCH BlueZ 7/9] client/gatt: proxy_property_changed: check for NULL iterator Christian Eggers
2022-09-23 10:27 ` [PATCH BlueZ 8/9] gatt: " Christian Eggers
2022-09-23 10:27 ` [PATCH BlueZ 9/9] battery: provided_battery_property_changed_cb: " Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923102421.10336-2-ceggers@arri.de \
--to=ceggers@arri.de \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.