All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, kvm@vger.kernel.org,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V2 RESEND 3/6] vDPA: check VIRTIO_NET_F_RSS for max_virtqueue_paris's presence
Date: Tue, 27 Sep 2022 11:01:14 +0800	[thread overview]
Message-ID: <20220927030117.5635-4-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220927030117.5635-1-lingshan.zhu@intel.com>

virtio 1.2 spec says:
max_virtqueue_pairs only exists if VIRTIO_NET_F_MQ or
VIRTIO_NET_F_RSS is set.

So when reporint MQ to userspace, it should check both
VIRTIO_NET_F_MQ and VIRTIO_NET_F_RSS.

unused parameter struct vdpa_device *vdev is removed

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 drivers/vdpa/vdpa.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index e7765953307f..829fd4cfc038 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -800,13 +800,13 @@ static int vdpa_nl_cmd_dev_get_dumpit(struct sk_buff *msg, struct netlink_callba
 	return msg->len;
 }
 
-static int vdpa_dev_net_mq_config_fill(struct vdpa_device *vdev,
-				       struct sk_buff *msg, u64 features,
+static int vdpa_dev_net_mq_config_fill(struct sk_buff *msg, u64 features,
 				       const struct virtio_net_config *config)
 {
 	u16 val_u16;
 
-	if ((features & BIT_ULL(VIRTIO_NET_F_MQ)) == 0)
+	if ((features & BIT_ULL(VIRTIO_NET_F_MQ)) == 0 &&
+	    (features & BIT_ULL(VIRTIO_NET_F_RSS)) == 0)
 		return 0;
 
 	val_u16 = le16_to_cpu(config->max_virtqueue_pairs);
-- 
2.31.1


  parent reply	other threads:[~2022-09-27  3:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  3:01 [PATCH V2 RESEND 0/6] Conditionally read fields in dev cfg space Zhu Lingshan
2022-09-27  3:01 ` [PATCH V2 RESEND 1/6] vDPA: allow userspace to query features of a vDPA device Zhu Lingshan
2022-09-27  4:36   ` Jason Wang
2022-09-27  4:36     ` Jason Wang
2022-09-27 10:02     ` Zhu, Lingshan
2022-09-27  3:01 ` [PATCH V2 RESEND 2/6] vDPA: only report driver features if FEATURES_OK is set Zhu Lingshan
2022-09-27  4:37   ` Jason Wang
2022-09-27  4:37     ` Jason Wang
2022-09-27 10:02     ` Zhu, Lingshan
2022-09-27  3:01 ` Zhu Lingshan [this message]
2022-09-27  4:38   ` [PATCH V2 RESEND 3/6] vDPA: check VIRTIO_NET_F_RSS for max_virtqueue_paris's presence Jason Wang
2022-09-27  4:38     ` Jason Wang
2022-09-27  3:01 ` [PATCH V2 RESEND 4/6] vDPA: check virtio device features to detect MQ Zhu Lingshan
2022-09-27  4:38   ` Jason Wang
2022-09-27  4:38     ` Jason Wang
2022-09-27  3:01 ` [PATCH V2 RESEND 5/6] vDPA: fix spars cast warning in vdpa_dev_net_mq_config_fill Zhu Lingshan
2022-09-27  4:38   ` Jason Wang
2022-09-27  4:38     ` Jason Wang
2022-09-27  3:01 ` [PATCH V2 RESEND 6/6] vDPA: conditionally read MTU and MAC in dev cfg space Zhu Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927030117.5635-4-lingshan.zhu@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.