From: Jeff Layton <jlayton@kernel.org>
To: tytso@mit.edu, adilger.kernel@dilger.ca, djwong@kernel.org,
david@fromorbit.com, trondmy@hammerspace.com, neilb@suse.de,
viro@zeniv.linux.org.uk, zohar@linux.ibm.com, xiubli@redhat.com,
chuck.lever@oracle.com, lczerner@redhat.com, jack@suse.cz,
bfields@fieldses.org, brauner@kernel.org, fweimer@redhat.com
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: [PATCH v8 0/8] fs: clean up internal i_version handling
Date: Fri, 21 Oct 2022 09:05:54 -0400 [thread overview]
Message-ID: <20221021130602.99099-1-jlayton@kernel.org> (raw)
The main consumer of i_version field (knfsd) has to jump through a
number of hoops to fetch it, depending on what sort of inode it is.
Rather than do this, we want to offload the responsibility for
presenting this field to the filesystem's ->getattr operation, which is
a more natural way to deal with a field that may be implemented
differently.
The focus of this patchset is to clean up these internal interfaces.
This should also make it simple to present this attribute to userland in
the future, which should be possible once the semantics are a bit more
consistent across different backing filesystems.
The change are fairly small, but they cross several subsystems. I'd
appreciate R-b's and A-b's from maintainers whose subsystems I'm
touching (Chuck, Al, Trond, and Xiubo in particular).
For now, I'm leaving out more siginificant behavioral changes to
i_version handling so that we can keep the focus on this set rather
narrow. The next stap is to get this into linux-next with an aim toward
merge in v6.2.
Thanks!
Jeff Layton (8):
fs: uninline inode_query_iversion
fs: clarify when the i_version counter must be updated
vfs: plumb i_version handling into struct kstat
nfs: report the inode version in getattr if requested
ceph: report the inode version in getattr if requested
nfsd: move nfsd4_change_attribute to nfsfh.c
nfsd: use the getattr operation to fetch i_version
nfsd: remove fetch_iversion export operation
fs/ceph/inode.c | 16 +++++++----
fs/libfs.c | 36 +++++++++++++++++++++++++
fs/nfs/export.c | 7 -----
fs/nfs/inode.c | 16 ++++++++---
fs/nfsd/nfs4xdr.c | 4 ++-
fs/nfsd/nfsfh.c | 42 +++++++++++++++++++++++++++++
fs/nfsd/nfsfh.h | 29 +-------------------
fs/nfsd/vfs.h | 7 ++++-
fs/stat.c | 17 ++++++++++--
include/linux/exportfs.h | 1 -
include/linux/iversion.h | 58 ++++++++++++++--------------------------
include/linux/stat.h | 9 +++++++
12 files changed, 155 insertions(+), 87 deletions(-)
--
2.37.3
next reply other threads:[~2022-10-21 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:05 Jeff Layton [this message]
2022-10-21 13:05 ` [PATCH v8 1/8] fs: uninline inode_query_iversion Jeff Layton
2022-10-21 13:05 ` [PATCH v8 2/8] fs: clarify when the i_version counter must be updated Jeff Layton
2022-10-21 13:05 ` [PATCH v8 3/8] vfs: plumb i_version handling into struct kstat Jeff Layton
2022-10-21 13:05 ` [PATCH v8 4/8] nfs: report the inode version in getattr if requested Jeff Layton
2022-10-21 13:05 ` [PATCH v8 5/8] ceph: " Jeff Layton
2022-10-21 13:06 ` [PATCH v8 6/8] nfsd: move nfsd4_change_attribute to nfsfh.c Jeff Layton
2022-10-21 13:06 ` [PATCH v8 7/8] nfsd: use the getattr operation to fetch i_version Jeff Layton
2022-10-21 13:06 ` [PATCH v8 8/8] nfsd: remove fetch_iversion export operation Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021130602.99099-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=bfields@fieldses.org \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fweimer@redhat.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trondmy@hammerspace.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiubli@redhat.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.