From: Xin Li <xin3.li@intel.com>
To: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
linux-kbuild@vger.kernel.org, x86@kernel.org
Cc: nathan@kernel.org, keescook@chromium.org,
andrew.cooper3@citrix.com, hpa@zytor.com, peterz@infradead.org
Subject: [PATCH v2 0/1] kbuild: upgrade the orphan section warning to an error if CONFIG_WERROR is set
Date: Tue, 25 Oct 2022 00:30:22 -0700 [thread overview]
Message-ID: <20221025073023.16137-1-xin3.li@intel.com> (raw)
Andrew Cooper suggested upgrading the orphan section warning to a hard link
error. However Nathan Chancellor said outright turning the warning into an
error with no escape hatch might be too aggressive, as we have had these
warnings triggered by new compiler generated sections, and suggested turning
orphan sections into an error only if CONFIG_WERROR is set. Kees Cook echoed
and emphasized that the mandate from Linus is that we should avoid breaking
builds. It wrecks bisection, it causes problems across compiler versions, etc.
Change since v1:
* Introduce a new Kconfig item CONFIG_LD_ORPHAN_WARN_LEVEL to replace
(if $(CONFIG_WERROR),error,warn) (Nathan Chancellor).
Xin Li (1):
kbuild: upgrade the orphan section warning to an error if
CONFIG_WERROR is set
Makefile | 2 +-
arch/arm/boot/compressed/Makefile | 2 +-
arch/arm64/kernel/vdso/Makefile | 2 +-
arch/arm64/kernel/vdso32/Makefile | 2 +-
arch/x86/boot/compressed/Makefile | 2 +-
init/Kconfig | 15 ++++++++++++---
6 files changed, 17 insertions(+), 8 deletions(-)
--
2.34.1
next reply other threads:[~2022-10-25 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:30 Xin Li [this message]
2022-10-25 7:30 ` [PATCH v2 1/1] kbuild: upgrade the orphan section warning to an error if CONFIG_WERROR is set Xin Li
2022-10-28 21:23 ` [PATCH v2 0/1] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025073023.16137-1-xin3.li@intel.com \
--to=xin3.li@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.