All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org, linux-block@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Cc: "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCH v4 0/7]
Date: Mon, 31 Oct 2022 10:53:22 +0900	[thread overview]
Message-ID: <20221031015329.141954-1-damien.lemoal@opensource.wdc.com> (raw)

These patches cleanup and improve libata support for the FUA device
feature. Patch 6 enables FUA support by default for any drive that
reports supporting the feature as well as NCQ.

Changes from v3:
- Added patch 1 to prevent any block device user from issuing a
  REQ_FUA read.
- Changed patch 5 to remove the check for REQ_FUA read and also remove 
  support for ATA_CMD_WRITE_MULTI_FUA_EXT as this command is obsolete
  in recent ACS specifications.

Changes from v2:
 - Added patch 1 and 2 as preparatory patches
 - Added patch 4 to fix FUA writes handling for the non-ncq case. Note
   that it is possible that the drives blacklisted in patch 5 are
   actually OK since the code back in 2012 had the issue with the wrong
   use of LBA 28 commands for FUA writes.

Changes from v1:
 - Removed Maciej's patch 2. Instead, blacklist drives which are known
   to have a buggy FUA support.

Damien Le Moal (7):
  block: Prevent the use of REQ_FUA with read operations
  ata: libata: Introduce ata_ncq_supported()
  ata: libata: Rename and cleanup ata_rwcmd_protocol()
  ata: libata: cleanup fua support detection
  ata: libata: Fix FUA handling in ata_build_rw_tf()
  ata: libata: blacklist FUA support for known buggy drives
  ata: libata: Enable fua support by default

 .../admin-guide/kernel-parameters.txt         |  3 +
 block/blk-flush.c                             | 12 +++
 drivers/ata/libata-core.c                     | 77 ++++++++++++++-----
 drivers/ata/libata-scsi.c                     | 30 +-------
 include/linux/libata.h                        | 34 +++++---
 5 files changed, 100 insertions(+), 56 deletions(-)

-- 
2.38.1


             reply	other threads:[~2022-10-31  1:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31  1:53 Damien Le Moal [this message]
2022-10-31  1:53 ` [PATCH v4 1/7] block: Prevent the use of REQ_FUA with read operations Damien Le Moal
2022-10-31  1:53 ` [PATCH v4 2/7] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-10-31  1:53 ` [PATCH v4 3/7] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-10-31  1:53 ` [PATCH v4 4/7] ata: libata: cleanup fua support detection Damien Le Moal
2022-10-31  1:53 ` [PATCH v4 5/7] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-11-02 14:25   ` Hannes Reinecke
2022-10-31  1:53 ` [PATCH v4 6/7] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-10-31  1:53 ` [PATCH v4 7/7] ata: libata: Enable fua support by default Damien Le Moal
2022-10-31  1:59 ` [PATCH v4 0/7] Chaitanya Kulkarni
2022-10-31  2:19   ` Damien Le Moal
  -- strict thread matches above, loose matches on Subject: below --
2016-09-20 20:42 [PATCH v3 0/2] Input: synaptics-rmi4 - F34 device reflash support Nick Dyer
2016-10-18 23:34 ` [PATCH v4 0/7] Nick Dyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221031015329.141954-1-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.