All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH v2 4/5] x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area()
Date: Fri,  4 Nov 2022 08:27:00 +0100	[thread overview]
Message-ID: <20221104072701.20283-5-jgross@suse.com> (raw)
In-Reply-To: <20221104072701.20283-1-jgross@suse.com>

Testing of X86_FEATURE_XENPV in setup_cpu_entry_area() can be removed,
as this code path is 32-bit only, and Xen PV guests are not supporting
32-bit mode.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- new patch
---
 arch/x86/mm/cpu_entry_area.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/x86/mm/cpu_entry_area.c b/arch/x86/mm/cpu_entry_area.c
index 6c2f1b76a0b6..42cd96e7d733 100644
--- a/arch/x86/mm/cpu_entry_area.c
+++ b/arch/x86/mm/cpu_entry_area.c
@@ -138,17 +138,13 @@ static void __init setup_cpu_entry_area(unsigned int cpu)
 	pgprot_t tss_prot = PAGE_KERNEL_RO;
 #else
 	/*
-	 * On native 32-bit systems, the GDT cannot be read-only because
+	 * On 32-bit systems, the GDT cannot be read-only because
 	 * our double fault handler uses a task gate, and entering through
 	 * a task gate needs to change an available TSS to busy.  If the
 	 * GDT is read-only, that will triple fault.  The TSS cannot be
 	 * read-only because the CPU writes to it on task switches.
-	 *
-	 * On Xen PV, the GDT must be read-only because the hypervisor
-	 * requires it.
 	 */
-	pgprot_t gdt_prot = boot_cpu_has(X86_FEATURE_XENPV) ?
-		PAGE_KERNEL_RO : PAGE_KERNEL;
+	pgprot_t gdt_prot = PAGE_KERNEL;
 	pgprot_t tss_prot = PAGE_KERNEL;
 #endif
 
-- 
2.35.3


  parent reply	other threads:[~2022-11-04  7:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  7:26 [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Juergen Gross
2022-11-04  7:26 ` [PATCH v2 1/5] x86: add X86_FEATURE_XENPV to disabled-features.h Juergen Gross
2022-11-04 14:56   ` Dave Hansen
2022-11-22 18:04   ` [tip: x86/cpu] x86/cpufeatures: Add " tip-bot2 for Juergen Gross
2022-11-04  7:26 ` [PATCH v2 2/5] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() Juergen Gross
2022-11-04 14:58   ` Dave Hansen
2022-11-22 18:04   ` [tip: x86/cpu] x86/cpu: Remove " tip-bot2 for Juergen Gross
2022-11-04  7:26 ` [PATCH v2 3/5] x86: drop 32-bit Xen PV guest code in update_task_stack() Juergen Gross
2022-11-04 15:04   ` Dave Hansen
2022-11-22 18:04   ` [tip: x86/cpu] x86/cpu: Drop " tip-bot2 for Juergen Gross
2022-11-04  7:27 ` Juergen Gross [this message]
2022-11-04 15:04   ` [PATCH v2 4/5] x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area() Dave Hansen
2022-11-22 18:04   ` [tip: x86/cpu] x86/cpu: Remove " tip-bot2 for Juergen Gross
2022-11-04  7:27 ` [PATCH v2 5/5] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Juergen Gross
2022-11-04 17:32   ` Dave Hansen
2022-11-22 18:04   ` [tip: x86/cpu] x86/cpu: Switch " tip-bot2 for Juergen Gross
2022-11-22 12:47 ` [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221104072701.20283-5-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.