From: kirill@shutemov.name
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
dave.hansen@linux.intel.com, jejb@linux.ibm.com,
linux-kernel@vger.kernel.org, lkp@intel.com,
martin.petersen@oracle.com, oe-kbuild-all@lists.linux.dev,
x86@kernel.org
Subject: Re: [PATCH 1/2] scsi: Fix get_user() in call sg_scsi_ioctl()
Date: Wed, 16 Nov 2022 03:55:29 +0300 [thread overview]
Message-ID: <20221116005529.uh4uol2qgcfnkfma@box.shutemov.name> (raw)
In-Reply-To: <9c96f82e-000b-88f8-fa37-753ed6723119@intel.com>
On Tue, Nov 15, 2022 at 04:48:40PM -0800, Dave Hansen wrote:
> On 11/15/22 16:43, Kirill A. Shutemov wrote:
> > get_user() expects the pointer to be pointer-to-simple-variable type,
> > but sic->data is array of 'unsigned char'. It violates get_user()
> > contracts.
> >
> > Cast it explicitly to 'unsigned char __user *'. It matches current
> > behaviour.
> >
> > This is preparation for fixing sparse warnings caused by Linear Address
> > Masking patchset.
>
> What's the side-effect if this isn't applied? Is it worse than sparse
> warnings?
Build will fail if 2/2 applied without this one:
arch/x86/include/asm/uaccess.h:46:9: error: cast specifies array type
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2022-11-16 0:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 21:41 [tip:x86/mm 5/16] sound/core/hwdep.c:243:24: sparse: sparse: incorrect type in assignment (different address spaces) kernel test robot
2022-11-14 22:55 ` Dave Hansen
2022-11-15 3:40 ` Kirill A. Shutemov
2022-11-15 15:58 ` Kirill A. Shutemov
2022-11-16 0:43 ` [PATCH 0/2] x86/mm: Fix sparse warning due to LAM patchset Kirill A. Shutemov
2022-11-16 0:43 ` [PATCH 1/2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-16 0:48 ` Dave Hansen
2022-11-16 0:55 ` kirill [this message]
2022-11-16 22:40 ` David Laight
2022-11-17 0:03 ` kirill
2022-11-16 0:43 ` [PATCH 2/2] x86/mm: Fix sparse warnings in untagged_ptr() Kirill A. Shutemov
2022-11-24 19:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116005529.uh4uol2qgcfnkfma@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.