From: Hou Tao <houtao@huaweicloud.com>
To: bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>,
David Vernet <void@manifault.com>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Hao Luo <haoluo@google.com>,
Yonghong Song <yhs@fb.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Jiri Olsa <jolsa@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
houtao1@huawei.com
Subject: [PATCH bpf v2 0/4] libbpf: Fixes for ring buffer
Date: Wed, 16 Nov 2022 15:23:47 +0800 [thread overview]
Message-ID: <20221116072351.1168938-1-houtao@huaweicloud.com> (raw)
From: Hou Tao <houtao1@huawei.com>
Hi,
The patch set tries to fix the problems found when testing ringbuf by
using 4KB and 2GB size. Patch 1 fixes the probe of ring buffer map on
host with 64KB page (e.g., an ARM64 host). Patch 2 & 3 fix the overflow
of length when mmaping 2GB kernel ringbuf or user ringbuf on libbpf.
Patch 4 just reject the reservation with invalid size.
Please see individual patch for details. And comments are always
welcome.
Change Log:
v2:
* patch 1: use page size instead of adjust_ringbuf_sz(4096) as main_entries (suggested by Stanislav)
* patch 2 & 3: use "mmap_sz" instead of "ro_size/wr_size" as name of mmap length (From Andrii)
v1: https://lore.kernel.org/bpf/20221111092642.2333724-1-houtao@huaweicloud.com
Hou Tao (4):
libbpf: Use page size as max_entries when probing ring buffer map
libbpf: Handle size overflow for ringbuf mmap
libbpf: Handle size overflow for user ringbuf mmap
libbpf: Check the validity of size in user_ring_buffer__reserve()
tools/lib/bpf/libbpf_probes.c | 2 +-
tools/lib/bpf/ringbuf.c | 26 ++++++++++++++++++++++----
2 files changed, 23 insertions(+), 5 deletions(-)
--
2.29.2
next reply other threads:[~2022-11-16 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 7:23 Hou Tao [this message]
2022-11-16 7:23 ` [PATCH bpf v2 1/4] libbpf: Use page size as max_entries when probing ring buffer map Hou Tao
2022-11-16 7:23 ` [PATCH bpf v2 2/4] libbpf: Handle size overflow for ringbuf mmap Hou Tao
2022-11-16 7:23 ` [PATCH bpf v2 3/4] libbpf: Handle size overflow for user " Hou Tao
2022-11-16 7:23 ` [PATCH bpf v2 4/4] libbpf: Check the validity of size in user_ring_buffer__reserve() Hou Tao
2022-11-18 0:00 ` [PATCH bpf v2 0/4] libbpf: Fixes for ring buffer patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116072351.1168938-1-houtao@huaweicloud.com \
--to=houtao@huaweicloud.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.