From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
thomas.lendacky@amd.com, "H. Peter Anvin" <hpa@zytor.com>,
hdegoede@redhat.com, Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave.hansen@linux.intel.com>,
David.Kaplan@amd.com, Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
antonio.gomez.iglesias@linux.intel.com
Subject: Re: [PATCH v3 2/2] x86/pm: Add enumeration check before spec MSRs save/restore setup
Date: Fri, 18 Nov 2022 10:27:52 -0800 [thread overview]
Message-ID: <20221118182752.7ovqckwwle3azzrc@desk> (raw)
In-Reply-To: <dc39988c-7b44-63b2-9ddf-6fa986fe7c3b@intel.com>
On Fri, Nov 18, 2022 at 10:12:32AM -0800, Dave Hansen wrote:
>On 11/15/22 11:17, Pawan Gupta wrote:
>> To fix this, add the corresponding X86_FEATURE bit for each MSR. Avoid
>> trying to manipulate the MSR when the feature bit is clear. This
>> required adding a X86_FEATURE bit for MSRs that do not have one already,
>> but it's a small price to pay.
>>
>> Fixes: 73924ec4d560 ("x86/pm: Save the MSR validity status at context setup")
>> Reported-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
>> Cc: stable@kernel.org
>
>Thanks for fixing this up. The X86_FEATURE approach is a good one. The
>"poking at random MSRs" always seemed a bit wonky.
>
>Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
Thanks.
prev parent reply other threads:[~2022-11-18 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 19:17 [PATCH v3 0/2] Check enumeration before MSR save/restore Pawan Gupta
2022-11-15 19:17 ` [PATCH v3 1/2] x86/tsx: Add feature bit for TSX control MSR support Pawan Gupta
2022-11-18 18:11 ` Dave Hansen
2022-11-15 19:17 ` [PATCH v3 2/2] x86/pm: Add enumeration check before spec MSRs save/restore setup Pawan Gupta
2022-11-15 19:23 ` Rafael J. Wysocki
2022-11-15 20:48 ` Pawan Gupta
2022-11-18 18:12 ` Dave Hansen
2022-11-18 18:27 ` Pawan Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118182752.7ovqckwwle3azzrc@desk \
--to=pawan.kumar.gupta@linux.intel.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=David.Kaplan@amd.com \
--cc=antonio.gomez.iglesias@linux.intel.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.