Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for Qualcomm SMBCHG

From: Yassine Oudjana <yassine.oudjana@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Alejandro Tafalla <atafalla@dnyon.com>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Yassine Oudjana <yassine.oudjana@gmail.com>,
	Yassine Oudjana <y.oudjana@protonmail.com>
Subject: Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for Qualcomm SMBCHG
Date: Sun, 20 Nov 2022 18:46:26 +0300	[thread overview]
Message-ID: <20221120154625.57095-1-y.oudjana@protonmail.com> (raw)
In-Reply-To: <dfaf7a35-25bb-8201-42bc-73ca280fcb69@linaro.org>

On Mon, 8 Aug 2022 11:42:34 +0300, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 08/08/2022 10:34, Yassine Oudjana wrote:
> > From: Yassine Oudjana <y.oudjana@protonmail.com>
> > 
> > Add DT schema for the switch-mode battery charger found on Qualcomm
> > PMICs such as PMI8994. Due to lack of documentation, some interrupt
> > descriptions might be inaccurate.
> > 
> > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> > ---
> >  .../bindings/power/supply/qcom,smbchg.yaml    | 205 ++++++++++++++++++
> >  MAINTAINERS                                   |   8 +
> >  2 files changed, 213 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
> > new file mode 100644
> > index 000000000000..d825a9c10b3e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/qcom,smbchg.yaml
> > @@ -0,0 +1,205 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/qcom,smbchg.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm PMIC Switch-Mode Battery Charger
> > +
> > +maintainers:
> > +  - Yassine Oudjana <y.oudjana@protonmail.com>
> > +  - Alejandro Tafalla <atafalla@dnyon.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,pmi8994-smbchg
> > +      - qcom,pmi8996-smbchg
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  monitored-battery:
> > +    description: |
> > +      phandle of battery characteristics node.
> > +      The charger uses the following properties:
> > +      - charge-term-current-microamp
> > +      - constant-charge-current-max-microamp
> > +      - voltage-max-design-microvolt
> > +      The constant-charge-current-max-microamp and voltage-max-design-microvolt
> > +      properties must be set.
> > +      See Documentation/devicetree/bindings/power/supply/battery.yaml
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Charger error
> > +      - description: Charger inhibited
> > +      - description: Charger precharge safety timer timeout
> > +      - description: Charger charge safety timer timeout
> > +      - description: Charger pre to fast charging switch threshold reached
> > +      - description: Charger recharge threshold reached
> > +      - description: Charger taper threshold reached
> > +      - description: Charger charge termination threshold reached
> > +      - description: Battery hot
> > +      - description: Battery warm
> > +      - description: Battery cold
> > +      - description: Battery cool
> > +      - description: Battery overvoltage
> > +      - description: Battery low
> > +      - description: Battery missing
> > +      - description: Battery thermistor missing # unconfirmed
> > +      - description: USB input undervolt
> > +      - description: USB input overvolt
> > +      - description: USB input source detected
> > +      - description: OTG regulator failure
> > +      - description: OTG regulator overcurrent
> > +      - description: Automatic input current limiting done
> > +      - description: USB ID pin changed
> > +      - description: DC input undervolt
> > +      - description: DC input overvolt
> > +      - description: Power OK
> > +      - description: Temperature shutdown
> > +      - description: Watchdog timeout
> > +      - description: Flash failure
> > +      - description: OTST2 # unknown
> > +      - description: OTST3 # unknown
> 
> It seems you listed register interrupts, not physical pins. This should
> be interrupt lines.

I'm not sure what I'm supposed to do here. I couldn't find an interrupt-lines
property used anywhere so that's not what you meant, right?