From: Alexey Romanov <avromanov@sberdevices.ru>
To: <minchan@kernel.org>, <senozhatsky@chromium.org>,
<ngupta@vflare.org>, <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<kernel@sberdevices.ru>, <ddrokosov@sberdevices.ru>,
Alexey Romanov <avromanov@sberdevices.ru>
Subject: [RFC PATCH v1 4/4] zram: recompression: add ZRAM_MERGED check
Date: Mon, 21 Nov 2022 22:00:20 +0300 [thread overview]
Message-ID: <20221121190020.66548-5-avromanov@sberdevices.ru> (raw)
In-Reply-To: <20221121190020.66548-1-avromanov@sberdevices.ru>
It is not possible to recompress merged pages in the current
implementation. Although, in the future it is possible to add
support for recompression of merged pages.
Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
drivers/block/zram/zram_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 7a267b37e5db..07661283ea15 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -2211,7 +2211,8 @@ static ssize_t recompress_store(struct device *dev,
if (zram_test_flag(zram, index, ZRAM_WB) ||
zram_test_flag(zram, index, ZRAM_UNDER_WB) ||
zram_test_flag(zram, index, ZRAM_SAME) ||
- zram_test_flag(zram, index, ZRAM_INCOMPRESSIBLE))
+ zram_test_flag(zram, index, ZRAM_INCOMPRESSIBLE) ||
+ zram_test_flag(zram, index, ZRAM_MERGED))
goto next;
err = zram_recompress(zram, index, page, threshold,
--
2.25.1
next prev parent reply other threads:[~2022-11-21 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 19:00 [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 1/4] zram: introduce " Alexey Romanov
2022-11-23 8:25 ` Chen Wandun
2022-11-23 9:04 ` Aleksey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 2/4] zram: add merge sysfs knob Alexey Romanov
2022-11-21 19:00 ` [RFC PATCH v1 3/4] zram: add pages_merged counter to mm_stat Alexey Romanov
2022-11-21 19:00 ` Alexey Romanov [this message]
2022-11-21 20:44 ` [RFC PATCH v1 0/4] Introduce merge identical pages mechanism Johannes Weiner
2022-11-22 3:00 ` Sergey Senozhatsky
2022-11-22 3:07 ` Sergey Senozhatsky
2022-11-22 12:14 ` Aleksey Romanov
2022-11-23 4:13 ` Sergey Senozhatsky
2022-11-23 8:53 ` Dmitry Rokosov
2022-12-01 10:14 ` Dmitry Rokosov
2022-12-01 10:47 ` Sergey Senozhatsky
2022-12-01 11:14 ` Dmitry Rokosov
2022-12-01 13:29 ` Sergey Senozhatsky
2023-01-11 14:00 ` Alexey Romanov
2023-02-06 10:37 ` Sergey Senozhatsky
2022-11-23 9:07 ` Aleksey Romanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121190020.66548-5-avromanov@sberdevices.ru \
--to=avromanov@sberdevices.ru \
--cc=akpm@linux-foundation.org \
--cc=ddrokosov@sberdevices.ru \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.