Re: [PATCH] can: ctucanfd: Drop obsolete dependency on COMPILE_TEST

From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-can@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Ondrej Ille <ondrej.ille@gmail.com>
Subject: Re: [PATCH] can: ctucanfd: Drop obsolete dependency on COMPILE_TEST
Date: Thu, 24 Nov 2022 15:56:38 +0100	[thread overview]
Message-ID: <202211241556.38957.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <20221124141604.4265225f@endymion.delvare>

Thanks for the care. I cannot judge change on my personal opinion.
But if that is general direction even for other drivers
then I confirm the change.

On Thursday 24 of November 2022 14:16:04 Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>
> Cc: Ondrej Ille <ondrej.ille@gmail.com>
> ---
>  drivers/net/can/ctucanfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-6.0.orig/drivers/net/can/ctucanfd/Kconfig
> +++ linux-6.0/drivers/net/can/ctucanfd/Kconfig
> @@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI
>
>  config CAN_CTUCANFD_PLATFORM
>  	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> -	depends on HAS_IOMEM && (OF || COMPILE_TEST)
> +	depends on HAS_IOMEM && OF
>  	select CAN_CTUCANFD
>  	help
>  	  The core has been tested together with OpenCores SJA1000