From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Russell King <linux@armlinux.org.uk>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: [PATCH v1 2/2] drm: tda99x: Don't advertise non-existent capture support
Date: Wed, 30 Nov 2022 18:46:44 +0000 [thread overview]
Message-ID: <20221130184644.464820-3-broonie@kernel.org> (raw)
In-Reply-To: <20221130184644.464820-1-broonie@kernel.org>
As far as I can tell none of the tda998x devices support audio capture so
don't advertise support for it, ensuring that we don't confuse userspace.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index d444e7fffb54..a14d2896aebb 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1174,6 +1174,8 @@ static int tda998x_audio_codec_init(struct tda998x_priv *priv,
struct hdmi_codec_pdata codec_data = {
.ops = &audio_codec_ops,
.max_i2s_channels = 2,
+ .no_i2s_capture = 1,
+ .no_spdif_capture = 1,
};
if (priv->audio_port_enable[AUDIO_ROUTE_I2S])
--
2.30.2
next prev parent reply other threads:[~2022-11-30 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 18:46 [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams Mark Brown
2022-11-30 18:46 ` [PATCH v1 1/2] ASoC: hdmi-codec: Allow playback and capture to be disabled Mark Brown
2022-11-30 18:46 ` Mark Brown [this message]
2022-12-02 13:55 ` [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams Russell King (Oracle)
2022-12-02 13:55 ` Russell King (Oracle)
2022-12-04 17:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130184644.464820-3-broonie@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.