From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: [PATCH v2 00/16] ASoC: Intel: avs: Data probing and fw logging
Date: Fri, 2 Dec 2022 16:28:25 +0100 [thread overview]
Message-ID: <20221202152841.672536-1-cezary.rojewski@intel.com> (raw)
The patchset focuses on debug functionality for the avs-driver.
Two major blocks are covered here: data probing and AudioDSP firmware
logging. Both are configured and controlled through debugfs.
Data probing is a AudioDSP debug functionality which allows for
gathering the actual data that is being routed to or from a module.
Helps in debugging its processing capabilities - navigate to a specific
module which may have caused a glitch within a pipeline (set of modules
bound together).
First few allow for assigning compress stream to a HDAudio stream, what
is currently limited to pcm substreams only. These patches were already
present on this list and reviewed in the past [1].
The next few tidy existing debug-related code up so it's ready for
addition of new functionalities and make it clear which part of the avs
is debug related and which is not. These also simplify the existing
locking around the trace fifo.
Afterward, debug-related IPCs are defined along with stub soc-component
and compress DAI operations. Not much is done there as it's not a
standard PCM streaming scenario. Most code found in compress operations
is inherited from the HOST side of HDAudio streaming found in pcm.c
file of the driver.
Finally, a debugfs file operations are defined. These facilitate
connecting to DSP modules from which the data shall be gathered as well
as control and configuration of firmware logging. Additionally, entries
are added to allow for dumping snapshots of key memory windows.
Changes in v2:
- reordered sign offs in patch 03 as reported by Takashi
- fixed issue reported by ikp - unintilialized 'runtime' variable in
patch 03
- added missing module_get_upon_open in component driver declaration
[1]: https://lore.kernel.org/alsa-devel/20200124190413.18154-1-cezary.rojewski@intel.com/
Cezary Rojewski (16):
ALSA: hda: Allow for compress stream to hdac_ext_stream assignment
ALSA: hda: Prepare for compress stream support
ALSA: hda: Interrupt servicing and BDL setup for compress streams
ASoC: Intel: avs: Introduce avs_log_buffer_status_locked()
ASoC: Intel: avs: Drop fifo_lock
ASoC: Intel: avs: Introduce debug-context aware helpers
ASoC: Intel: avs: Make enable_logs() dependent on DEBUG_FS
ASoC: Intel: avs: Drop usage of debug members in non-debug code
ASoC: Intel: avs: Add data probing requests
ASoC: Intel: avs: Probe compress operations
ASoC: Intel: avs: Data probing soc-component
ASoC: Intel: avs: Add probe machine board
ASoC: Intel: avs: Probing and firmware tracing over debugfs
ASoC: Intel: avs: Gather remaining logs on strace_release()
ASoC: Intel: avs: Allow for dumping FW_REGS area
ASoC: Intel: avs: Allow for dumping debug window snapshot
include/sound/hdaudio_ext.h | 2 +
sound/hda/ext/hdac_ext_stream.c | 41 +++
sound/hda/hdac_controller.c | 4 +-
sound/hda/hdac_stream.c | 51 +--
sound/soc/intel/Kconfig | 1 +
sound/soc/intel/avs/Makefile | 4 +
sound/soc/intel/avs/apl.c | 24 +-
sound/soc/intel/avs/avs.h | 80 ++++-
sound/soc/intel/avs/board_selection.c | 33 ++
sound/soc/intel/avs/boards/Kconfig | 8 +
sound/soc/intel/avs/boards/Makefile | 2 +
sound/soc/intel/avs/boards/probe.c | 64 ++++
sound/soc/intel/avs/core.c | 2 +
sound/soc/intel/avs/debugfs.c | 436 ++++++++++++++++++++++++++
sound/soc/intel/avs/ipc.c | 2 +-
sound/soc/intel/avs/messages.c | 104 +++++-
sound/soc/intel/avs/messages.h | 53 ++++
sound/soc/intel/avs/pcm.c | 6 +-
sound/soc/intel/avs/probes.c | 313 ++++++++++++++++++
sound/soc/intel/avs/registers.h | 3 +-
sound/soc/intel/avs/skl.c | 17 +-
sound/soc/intel/avs/utils.c | 22 --
22 files changed, 1172 insertions(+), 100 deletions(-)
create mode 100644 sound/soc/intel/avs/boards/probe.c
create mode 100644 sound/soc/intel/avs/debugfs.c
create mode 100644 sound/soc/intel/avs/probes.c
--
2.25.1
next reply other threads:[~2022-12-02 15:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 15:28 Cezary Rojewski [this message]
2022-12-02 15:28 ` [PATCH v2 01/16] ALSA: hda: Allow for compress stream to hdac_ext_stream assignment Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 02/16] ALSA: hda: Prepare for compress stream support Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 03/16] ALSA: hda: Interrupt servicing and BDL setup for compress streams Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 04/16] ASoC: Intel: avs: Introduce avs_log_buffer_status_locked() Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 05/16] ASoC: Intel: avs: Drop fifo_lock Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 06/16] ASoC: Intel: avs: Introduce debug-context aware helpers Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 07/16] ASoC: Intel: avs: Make enable_logs() dependent on DEBUG_FS Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 08/16] ASoC: Intel: avs: Drop usage of debug members in non-debug code Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 09/16] ASoC: Intel: avs: Add data probing requests Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 10/16] ASoC: Intel: avs: Probe compress operations Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 11/16] ASoC: Intel: avs: Data probing soc-component Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 12/16] ASoC: Intel: avs: Add probe machine board Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 13/16] ASoC: Intel: avs: Probing and firmware tracing over debugfs Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 14/16] ASoC: Intel: avs: Gather remaining logs on strace_release() Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 15/16] ASoC: Intel: avs: Allow for dumping FW_REGS area Cezary Rojewski
2022-12-02 15:28 ` [PATCH v2 16/16] ASoC: Intel: avs: Allow for dumping debug window snapshot Cezary Rojewski
2022-12-05 19:02 ` [PATCH v2 00/16] ASoC: Intel: avs: Data probing and fw logging Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202152841.672536-1-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.