All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: <jgg@nvidia.com>, <kvm@vger.kernel.org>, <kevin.tian@intel.com>,
	<joao.m.martins@oracle.com>, <leonro@nvidia.com>,
	<shayd@nvidia.com>, <maorg@nvidia.com>, <avihaih@nvidia.com>,
	<cohuck@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
	saeedm@nvidia.com
Subject: Re: [PATCH V3 vfio 01/14] net/mlx5: Introduce ifc bits for pre_copy
Date: Mon, 5 Dec 2022 08:22:00 -0700	[thread overview]
Message-ID: <20221205082200.6667589c.alex.williamson@redhat.com> (raw)
In-Reply-To: <20221205144838.245287-2-yishaih@nvidia.com>

On Mon, 5 Dec 2022 16:48:25 +0200
Yishai Hadas <yishaih@nvidia.com> wrote:

> From: Shay Drory <shayd@nvidia.com>
> 
> Introduce ifc related stuff to enable PRE_COPY of VF during migration.
> 
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>

This will need an ack from Leon or Saeed to go through the vfio tree.
Thanks,

Alex

> ---
>  include/linux/mlx5/mlx5_ifc.h | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 5a4e914e2a6f..230a96626a5f 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -1882,7 +1882,12 @@ struct mlx5_ifc_cmd_hca_cap_2_bits {
>  	u8	   max_reformat_remove_size[0x8];
>  	u8	   max_reformat_remove_offset[0x8];
>  
> -	u8	   reserved_at_c0[0xe0];
> +	u8	   reserved_at_c0[0x8];
> +	u8	   migration_multi_load[0x1];
> +	u8	   migration_tracking_state[0x1];
> +	u8	   reserved_at_ca[0x16];
> +
> +	u8	   reserved_at_e0[0xc0];
>  
>  	u8	   reserved_at_1a0[0xb];
>  	u8	   log_min_mkey_entity_size[0x5];
> @@ -11918,7 +11923,8 @@ struct mlx5_ifc_query_vhca_migration_state_in_bits {
>  	u8         reserved_at_20[0x10];
>  	u8         op_mod[0x10];
>  
> -	u8         reserved_at_40[0x10];
> +	u8         incremental[0x1];
> +	u8         reserved_at_41[0xf];
>  	u8         vhca_id[0x10];
>  
>  	u8         reserved_at_60[0x20];
> @@ -11944,7 +11950,9 @@ struct mlx5_ifc_save_vhca_state_in_bits {
>  	u8         reserved_at_20[0x10];
>  	u8         op_mod[0x10];
>  
> -	u8         reserved_at_40[0x10];
> +	u8         incremental[0x1];
> +	u8         set_track[0x1];
> +	u8         reserved_at_42[0xe];
>  	u8         vhca_id[0x10];
>  
>  	u8         reserved_at_60[0x20];


  reply	other threads:[~2022-12-05 15:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 14:48 [PATCH V3 vfio 00/14] Add migration PRE_COPY support for mlx5 driver Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 01/14] net/mlx5: Introduce ifc bits for pre_copy Yishai Hadas
2022-12-05 15:22   ` Alex Williamson [this message]
2022-12-05 16:29   ` Leon Romanovsky
2022-12-05 14:48 ` [PATCH V3 vfio 02/14] vfio: Extend the device migration protocol with PRE_COPY Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 03/14] vfio/mlx5: Enforce a single SAVE command at a time Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 04/14] vfio/mlx5: Refactor PD usage Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 05/14] vfio/mlx5: Refactor MKEY usage Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 06/14] vfio/mlx5: Refactor migration file state Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 07/14] vfio/mlx5: Refactor to use queue based data chunks Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 08/14] vfio/mlx5: Introduce device transitions of PRE_COPY Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 09/14] vfio/mlx5: Introduce SW headers for migration states Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 10/14] vfio/mlx5: Introduce vfio precopy ioctl implementation Yishai Hadas
2022-12-05 19:03   ` Alex Williamson
2022-12-05 14:48 ` [PATCH V3 vfio 11/14] vfio/mlx5: Consider temporary end of stream as part of PRE_COPY Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 12/14] vfio/mlx5: Introduce multiple loads Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 13/14] vfio/mlx5: Fallback to STOP_COPY upon specific PRE_COPY error Yishai Hadas
2022-12-05 14:48 ` [PATCH V3 vfio 14/14] vfio/mlx5: Enable MIGRATION_PRE_COPY flag Yishai Hadas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205082200.6667589c.alex.williamson@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=leonro@nvidia.com \
    --cc=maorg@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=shayd@nvidia.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.