From: SeongJae Park <sj@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>, SeongJae Park <sj@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
damon@lists.linux.dev, vishal.moola@gmail.com,
willy@infradead.org
Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page()
Date: Tue, 13 Dec 2022 19:26:33 +0000 [thread overview]
Message-ID: <20221213192633.138774-1-sj@kernel.org> (raw)
In-Reply-To: <20221213092735.187924-9-wangkefeng.wang@huawei.com>
Hi Kefeng,
On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> After all damon_get_page() callers are converted to damon_get_folio(),
> remove unneed wrapper damon_get_page().
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/damon/ops-common.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
> index 4ee607813981..35a2e42a27da 100644
> --- a/mm/damon/ops-common.h
> +++ b/mm/damon/ops-common.h
> @@ -8,13 +8,6 @@
> #include <linux/damon.h>
>
> struct folio *damon_get_folio(unsigned long pfn);
> -static inline struct page *damon_get_page(unsigned long pfn)
> -{
> - struct folio *folio = damon_get_folio(pfn);
> -
> - return &folio->page;
> -}
> -
> void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr);
Let's keep the one blank line before damon_ptep_mkold().
> void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr);
>
> --
> 2.35.3
Thanks,
SJ
prev parent reply other threads:[~2022-12-13 19:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:27 [PATCH -next 0/8] mm: converted page idle and damon to use folios Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 1/8] mm: memory_hotplug: add pfn_to_online_folio() Kefeng Wang
2022-12-13 11:13 ` kernel test robot
2022-12-13 11:36 ` Kefeng Wang
2022-12-13 11:23 ` kernel test robot
2022-12-13 11:40 ` David Hildenbrand
2022-12-13 12:13 ` Kefeng Wang
2022-12-13 14:42 ` David Hildenbrand
2022-12-13 14:47 ` Matthew Wilcox
2022-12-14 1:10 ` Kefeng Wang
2022-12-13 12:03 ` kernel test robot
2022-12-14 4:15 ` kernel test robot
2022-12-13 9:27 ` [PATCH -next 2/8] mm: page_idle: Convert page idle to use folios Kefeng Wang
2022-12-13 14:34 ` Matthew Wilcox
2022-12-13 19:14 ` SeongJae Park
2022-12-13 9:27 ` [PATCH -next 3/8] mm: huge_memory: convert split_huge_pages_all() " Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 4/8] mm: damon: add temporary damon_get_folio() Kefeng Wang
2022-12-13 14:40 ` Matthew Wilcox
2022-12-13 19:18 ` SeongJae Park
2022-12-13 9:27 ` [PATCH -next 5/8] mm: damon: convert damon_ptep/pmdp_mkold() to use folios Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 6/8] mm: damon: paddr: convert damon_pa_*() " Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 7/8] mm: damon: vaddr: convert damon_young_pmd_entry() to use folio Kefeng Wang
2022-12-13 9:27 ` [PATCH -next 8/8] mm: damon: remove unneed damon_get_page() Kefeng Wang
2022-12-13 19:26 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213192633.138774-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.