From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Willy Tarreau <w@1wt.eu>, Shuah Khan <shuah@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
Gilang Fachrezy <gilang4321@gmail.com>,
VNLX Kernel Department <kernel@vnlx.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Kanna Scarlet <knscarlet@gnuweeb.org>,
Muhammad Rizki <kiizuha@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kselftest Mailing List <linux-kselftest@vger.kernel.org>
Subject: [RFC PATCH v1 4/8] selftests/nolibc: Add `-Wall` and `-Wno-unsed-function` to the CFLAGS
Date: Thu, 22 Dec 2022 10:51:30 +0700 [thread overview]
Message-ID: <20221222035134.3467659-5-ammar.faizi@intel.com> (raw)
In-Reply-To: <20221222035134.3467659-1-ammar.faizi@intel.com>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Turn on more compiler warnings to help spot issues. Skip unused
function warning as it's inevitable in the nolibc test suite.
While adding these flags, remove unused variables in run_stdlib()
warned by the `-Wall` flag.
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
tools/testing/selftests/nolibc/Makefile | 2 +-
tools/testing/selftests/nolibc/nolibc-test.c | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
index 572fe72df68d..f6602a2c2bbd 100644
--- a/tools/testing/selftests/nolibc/Makefile
+++ b/tools/testing/selftests/nolibc/Makefile
@@ -66,7 +66,7 @@ else
Q=@
endif
-CFLAGS ?= -Os -fno-ident -fno-asynchronous-unwind-tables
+CFLAGS ?= -Os -fno-ident -fno-asynchronous-unwind-tables -Wall -Wno-unused-function
LDFLAGS := -s
help:
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index f14f5076fb6d..8d69f8a0f35a 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -542,9 +542,7 @@ int run_syscall(int min, int max)
int run_stdlib(int min, int max)
{
int test;
- int tmp;
int ret = 0;
- void *p1, *p2;
for (test = min; test >= 0 && test <= max; test++) {
int llen = 0; // line length
--
Ammar Faizi
next prev parent reply other threads:[~2022-12-22 3:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 3:51 [RFC PATCH v1 0/8] nolibc signal handling support Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 1/8] nolibc/sys: Implement `sigaction(2)` function Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 2/8] nolibc/sys: Implement `signal(2)` function Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 3/8] nolibc/sys: Implement `getpagesize(2)` function Ammar Faizi
2022-12-22 3:51 ` Ammar Faizi [this message]
2022-12-22 3:51 ` [RFC PATCH v1 5/8] selftests/nolibc: Add `fork(2)` selftest Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 6/8] selftests/nolibc: Add `sigaction(2)` selftest Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 7/8] selftests/nolibc: Add `signal(2)` selftest Ammar Faizi
2022-12-22 3:51 ` [RFC PATCH v1 8/8] selftests/nolibc: Add `getpagesize(2)` selftest Ammar Faizi
2022-12-22 4:34 ` [RFC PATCH v1 0/8] nolibc signal handling support Willy Tarreau
2022-12-22 13:46 ` Ammar Faizi
2022-12-27 6:26 ` Willy Tarreau
2022-12-27 13:32 ` Ammar Faizi
2022-12-27 13:36 ` Ammar Faizi
2022-12-27 18:58 ` Willy Tarreau
2022-12-28 12:23 ` Ammar Faizi
2022-12-27 18:49 ` Willy Tarreau
2022-12-28 12:01 ` Ammar Faizi
2022-12-28 13:35 ` Willy Tarreau
2022-12-29 11:41 ` Ammar Faizi
2023-01-03 3:51 ` Alviro Iskandar Setiawan
2023-01-03 3:54 ` Willy Tarreau
2023-01-03 3:59 ` Ammar Faizi
2023-01-08 13:08 ` [PATCH v1 0/3] nolibc auxiliary vector retrieval support Ammar Faizi
2023-01-08 13:08 ` [PATCH v1 1/3] nolibc/stdlib: Implement `getauxval(3)` function Ammar Faizi
2023-01-08 13:08 ` [PATCH v1 2/3] nolibc/sys: Implement `getpagesize(2)` function Ammar Faizi
2023-01-08 13:08 ` [PATCH v1 3/3] selftests/nolibc: Add `getpagesize(2)` selftest Ammar Faizi
2023-01-08 13:10 ` [PATCH v2 0/4] nolibc signal handling support Ammar Faizi
2023-01-08 13:10 ` [PATCH v2 1/4] nolibc/sys: Implement `sigaction(2)` function Ammar Faizi
2023-01-08 13:10 ` [PATCH v2 2/4] nolibc/sys: Implement `signal(2)` function Ammar Faizi
2023-01-08 13:10 ` [PATCH v2 3/4] selftests/nolibc: Add `fork(2)` selftest Ammar Faizi
2023-01-08 13:10 ` [PATCH v2 4/4] selftests/nolibc: Add `sigaction(2)` selftest Ammar Faizi
2023-01-08 13:28 ` [PATCH v2 0/4] nolibc signal handling support Alviro Iskandar Setiawan
2023-01-08 13:31 ` Ammar Faizi
2023-01-08 13:39 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222035134.3467659-5-ammar.faizi@intel.com \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gilang4321@gmail.com \
--cc=gwml@vger.gnuweeb.org \
--cc=kernel@vnlx.org \
--cc=kiizuha@gnuweeb.org \
--cc=knscarlet@gnuweeb.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=shuah@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.