From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Tony Battersby <tonyb@cybernetics.com>,
Kernel Team <kernel-team@meta.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 09/12] dmapool: simplify freeing
Date: Sun, 8 Jan 2023 18:08:24 +0100 [thread overview]
Message-ID: <20230108170824.GD19739@lst.de> (raw)
In-Reply-To: <20230103191551.3254778-10-kbusch@meta.com>
> - * DMA Pool allocator
> +* DMA Pool allocator
This got corrupted somehow.
> + if (!is_page_busy(page))
> + dma_free_coherent(pool->dev, pool->allocation,
> + page->vaddr, page->dma);
> + else
> dev_err(pool->dev, "%s %s, %p busy\n", __func__,
> pool->name, page->vaddr);
> + list_del(&page->page_list);
> + kfree(page);
I'm still not sure what the point of leaking the page in case it is
busy vs letting KASAN and friends actually catch it, but the pure
rearrangement is an improvement over the previous state, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-01-08 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:15 [PATCHv3 00/12] dmapool enhancements Keith Busch
2023-01-03 19:15 ` [PATCHv3 01/12] dmapool: add alloc/free performance test Keith Busch
2023-01-03 19:15 ` [PATCHv3 02/12] dmapool: remove checks for dev == NULL Keith Busch
2023-01-03 19:15 ` [PATCHv3 03/12] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2023-01-03 19:15 ` [PATCHv3 04/12] dmapool: cleanup integer types Keith Busch
2023-01-03 19:15 ` [PATCHv3 05/12] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Keith Busch
2023-01-03 19:15 ` [PATCHv3 06/12] dmapool: move debug code to own functions Keith Busch
2023-01-08 17:06 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 07/12] dmapool: rearrange page alloc failure handling Keith Busch
2023-01-03 19:15 ` [PATCHv3 08/12] dmapool: consolidate page initialization Keith Busch
2023-01-08 17:07 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 09/12] dmapool: simplify freeing Keith Busch
2023-01-08 17:08 ` Christoph Hellwig [this message]
2023-01-03 19:15 ` [PATCHv3 10/12] dmapool: don't memset on free twice Keith Busch
2023-01-03 19:15 ` [PATCHv3 11/12] dmapool: link blocks across pages Keith Busch
2023-01-08 17:08 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 12/12] dmapool: create/destroy cleanup Keith Busch
2023-01-08 17:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108170824.GD19739@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tonyb@cybernetics.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.