From: Henrik Carlqvist <hc94@poolhem.se>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH qemu v3 0/1] Emulating sun keyboard language layout dip switches
Date: Sun, 8 Jan 2023 17:11:11 +0100 [thread overview]
Message-ID: <20230108171111.4d2a2201.hc94@poolhem.se> (raw)
In-Reply-To: <TY0PR0101MB4285AC0905312A82102F3348A4F99@TY0PR0101MB4285.apcprd01.prod.exchangelabs.com>
> Year 2020 I made 2 attempts to contribute this patch. Unfortunately "git
> format-patch" produced crippled patches which were not possible to
> apply. Some @@-lines got extra code that didn't belong in those lines.
> Now I am instead trying to send my patch using sourcehut. Unfortunately,
> it seems as if the patch created by sourcehut is still crippled,
Much to my surprise, it seems as if the patch created and sent by sourcehut
applies cleanly. I falsely thought that it was the source text after the @@
lines that caused the problems, but it turned out that when I sent my first
attempts by mail lines got wrapped by my email client and those wrapped lines
caused the problem.
The patch v2 which 2020 I created manually with git and sent by email got a
nice"singed-off-by" line, the patch v3 created by sourcehut misses that line.
Is the missing signed-off-by line a show stopper? If so, is sourcehut somehow
usable to post patches? If sourcehut is unusable for this purpose I might have
to send the patch as email again, but to avoid lines getting wrapped I will
then post them as attachements instead of the preferred way as inline in the
email text.
regards Henrik
next prev parent reply other threads:[~2023-01-08 16:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 12:30 [PATCH] target/i386/gdbstub: Fix a bug about order of FPU stack in 'g' packets TaiseiIto
2022-12-18 19:54 ` Richard Henderson
2022-12-19 4:01 ` TaiseiIto
2022-12-19 4:04 ` TaiseiIto
2022-12-19 15:40 ` Alex Bennée
2022-12-19 18:11 ` Richard Henderson
2023-01-07 1:28 ` [PATCH v2] [PING] " TaiseiIto
2023-01-07 10:15 ` Alex Bennée
2023-01-08 2:07 ` 伊藤 太清
2023-01-08 16:11 ` Henrik Carlqvist [this message]
2023-02-04 4:23 ` [PATCH v2] [PING^2] " TaiseiIto
2023-02-11 4:09 ` [PATCH v2] [PING^3] " TaiseiIto
2023-02-13 9:38 ` Alex Bennée
2023-02-15 12:00 ` [PATCH] [PING] " TaiseiIto
2023-02-15 12:36 ` [PATCH] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108171111.4d2a2201.hc94@poolhem.se \
--to=hc94@poolhem.se \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.