From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH v2 1/2] arm64: Always load shadow stack pointer directly from the task struct
Date: Thu, 12 Jan 2023 14:18:51 -0800 [thread overview]
Message-ID: <202301121418.CF87AD042@keescook> (raw)
In-Reply-To: <20230109174800.3286265-2-ardb@kernel.org>
On Mon, Jan 09, 2023 at 06:47:59PM +0100, Ard Biesheuvel wrote:
> All occurrences of the scs_load macro load the value of the shadow call
> stack pointer from the task which is current at that point. So instead
> of taking a task struct register argument in the scs_load macro to
> specify the task struct to load from, let's always reference the current
> task directly. This should make it much harder to exploit any
> instruction sequences reloading the shadow call stack pointer register
> from memory.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-12 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 17:47 [PATCH v2 0/2] arm64: harden shadow call stack pointer handling Ard Biesheuvel
2023-01-09 17:47 ` [PATCH v2 1/2] arm64: Always load shadow stack pointer directly from the task struct Ard Biesheuvel
2023-01-10 14:55 ` Mark Rutland
2023-01-12 22:18 ` Kees Cook [this message]
2023-01-09 17:48 ` [PATCH v2 2/2] arm64: Stash shadow stack pointer in the task struct on interrupt Ard Biesheuvel
2023-01-10 14:57 ` Mark Rutland
2023-01-12 22:18 ` Kees Cook
2023-01-20 16:59 ` [PATCH v2 0/2] arm64: harden shadow call stack pointer handling Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301121418.CF87AD042@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.