From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh@kernel.org>
Subject: [PATCH v2 3/7] dt-bindings: watchdog: qcom-wdt: fix list of MSM timer compatibles
Date: Fri, 13 Jan 2023 11:33:42 +0100 [thread overview]
Message-ID: <20230113103346.29381-4-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230113103346.29381-1-krzysztof.kozlowski@linaro.org>
The MSM timer ("qcom,msm-timer") is a bit different timer and watchdog
device than KPSS watchdog. It has its own generic and specific
compatibles, so fix the list to reflect this. Adjust the example to
show the newer KPSS watchdog.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes since v1:
1. Add tag.
---
.../devicetree/bindings/watchdog/qcom-wdt.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 3e0b30a817d6..93e4381067dd 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -33,13 +33,16 @@ properties:
- const: qcom,kpss-wdt
- const: qcom,kpss-wdt
deprecated: true
+ - items:
+ - const: qcom,scss-timer
+ - const: qcom,msm-timer
- items:
- enum:
- - qcom,kpss-timer
- qcom,kpss-wdt-apq8064
- qcom,kpss-wdt-ipq8064
- qcom,kpss-wdt-msm8960
- - qcom,scss-timer
+ - const: qcom,kpss-timer
+ - const: qcom,msm-timer
reg:
maxItems: 1
@@ -56,9 +59,11 @@ unevaluatedProperties: false
examples:
- |
- watchdog@208a038 {
- compatible = "qcom,kpss-wdt-ipq8064";
- reg = <0x0208a038 0x40>;
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ watchdog@17c10000 {
+ compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt";
+ reg = <0x17c10000 0x1000>;
clocks = <&sleep_clk>;
timeout-sec = <10>;
};
--
2.34.1
next prev parent reply other threads:[~2023-01-13 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 10:33 [PATCH v2 0/7] watchdog: dt-bindings: rework/fix qcom-wdt Krzysztof Kozlowski
2023-01-13 10:33 ` [PATCH v2 1/7] dt-bindings: watchdog: qcom-wdt: require fallback for IPQ4019 Krzysztof Kozlowski
2023-01-13 14:02 ` Guenter Roeck
2023-02-07 9:17 ` Krzysztof Kozlowski
2023-02-07 15:51 ` Guenter Roeck
2023-01-13 10:33 ` [PATCH v2 2/7] dt-bindings: watchdog: qcom-wdt: do not allow fallback alone Krzysztof Kozlowski
2023-01-13 14:02 ` Guenter Roeck
2023-01-13 10:33 ` Krzysztof Kozlowski [this message]
2023-01-13 14:02 ` [PATCH v2 3/7] dt-bindings: watchdog: qcom-wdt: fix list of MSM timer compatibles Guenter Roeck
2023-01-13 10:33 ` [PATCH v2 4/7] dt-bindings: watchdog: qcom-wdt: add qcom,kpss-wdt-mdm9615 Krzysztof Kozlowski
2023-01-13 14:03 ` Guenter Roeck
2023-01-13 10:33 ` [PATCH v2 5/7] dt-bindings: watchdog: qcom-wdt: allow interrupts Krzysztof Kozlowski
2023-01-13 14:03 ` Guenter Roeck
2023-01-13 10:33 ` [PATCH v2 6/7] dt-bindings: watchdog: qcom-wdt: merge MSM timer Krzysztof Kozlowski
2023-01-13 14:03 ` Guenter Roeck
2023-01-17 18:13 ` Rob Herring
2023-01-13 10:33 ` [PATCH v2 7/7] dt-bindings: watchdog: allow "timer" as node name Krzysztof Kozlowski
2023-01-13 14:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113103346.29381-4-krzysztof.kozlowski@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.