From: kernel test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] thermal/core: Move the thermal trip code to a dedicated file
Date: Thu, 19 Jan 2023 10:39:07 +0800 [thread overview]
Message-ID: <202301191017.G3eBi85j-lkp@intel.com> (raw)
In-Reply-To: <20230118211123.111493-4-daniel.lezcano@linaro.org>
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on next-20230118]
[cannot apply to linus/master v6.2-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Lezcano/thermal-core-Remove-unneeded-ida_destroy/20230119-051422
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20230118211123.111493-4-daniel.lezcano%40linaro.org
patch subject: [PATCH 4/5] thermal/core: Move the thermal trip code to a dedicated file
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230119/202301191017.G3eBi85j-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/039f53e8f2c0e0711f85537055e169fb216a29a9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Remove-unneeded-ida_destroy/20230119-051422
git checkout 039f53e8f2c0e0711f85537055e169fb216a29a9
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/thermal_trip.c:12:5: warning: no previous prototype for '__for_each_thermal_trip' [-Wmissing-prototypes]
12 | int __for_each_thermal_trip(struct thermal_zone_device *tz,
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/__for_each_thermal_trip +12 drivers/thermal/thermal_trip.c
11
> 12 int __for_each_thermal_trip(struct thermal_zone_device *tz,
13 int (*cb)(struct thermal_trip *,
14 int trip_id, void *),
15 void *data)
16 {
17 int i, ret;
18 struct thermal_trip trip;
19
20 for (i = 0; i < tz->num_trips; i++) {
21
22 ret = __thermal_zone_get_trip(tz, i, &trip);
23 if (ret)
24 return ret;
25
26 ret = cb(&trip, i, data);
27 if (ret)
28 return ret;
29 }
30
31 return 0;
32 }
33
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-01-19 2:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 21:11 [PATCH 1/5] thermal/core: Fix unregistering netlink at thermal init time Daniel Lezcano
2023-01-18 21:11 ` [PATCH 2/5] thermal/core: Remove unneeded ida_destroy() Daniel Lezcano
2023-01-18 21:11 ` [PATCH 3/5] thermal/core: Remove unneeded mutex_destroy() Daniel Lezcano
2023-01-19 7:41 ` Zhang, Rui
2023-01-19 9:30 ` Daniel Lezcano
2023-01-19 12:11 ` Rafael J. Wysocki
2023-01-19 12:48 ` Daniel Lezcano
2023-01-19 13:24 ` Rafael J. Wysocki
2023-01-19 14:13 ` Daniel Lezcano
2023-01-19 15:05 ` Rafael J. Wysocki
2023-01-19 16:39 ` Daniel Lezcano
2023-01-19 17:21 ` Rafael J. Wysocki
2023-01-20 14:09 ` Zhang, Rui
2023-01-20 14:13 ` Rafael J. Wysocki
2023-01-18 21:11 ` [PATCH 4/5] thermal/core: Move the thermal trip code to a dedicated file Daniel Lezcano
2023-01-19 2:39 ` kernel test robot [this message]
2023-01-19 7:24 ` Zhang, Rui
2023-01-18 21:11 ` [PATCH 5/5] thermal/core: Sort the trip points when registering a thermal zone Daniel Lezcano
2023-01-19 7:22 ` Zhang, Rui
2023-01-19 10:25 ` Daniel Lezcano
2023-01-19 16:50 ` Zhang, Rui
2023-01-19 13:28 ` [PATCH 1/5] thermal/core: Fix unregistering netlink at thermal init time Rafael J. Wysocki
2023-01-19 13:40 ` Daniel Lezcano
2023-01-19 13:45 ` Rafael J. Wysocki
2023-01-19 14:07 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301191017.G3eBi85j-lkp@intel.com \
--to=lkp@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.