Re: [PATCH 2/2] common: Unmount udf filesystem prior checking

From: David Disseldorp <ddiss@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: <fstests@vger.kernel.org>
Subject: Re: [PATCH 2/2] common: Unmount udf filesystem prior checking
Date: Fri, 20 Jan 2023 15:42:48 +0100	[thread overview]
Message-ID: <20230120154248.0f5aee8b@echidna.fritz.box> (raw)
In-Reply-To: <20230119105410.9236-2-jack@suse.cz>

On Thu, 19 Jan 2023 11:54:03 +0100, Jan Kara wrote:

> _check_udf_filesystem forgot to unmount the filesystem prior to checking
> it. That was leading to check failures.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  common/rc | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index de94e5a4cde4..df6f237cabaa 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3074,6 +3074,12 @@ _check_udf_filesystem()
>  	return
>      fi
>  
> +    # Is the filesystem mounted?
> +    local type=`_fs_type $device`
> +    if [ "$type" = "$FSTYP" ]; then
> +	local mountpoint=`_umount_or_remount_ro $device`
> +    fi
> +
>      local device=$1
>      local blksz=`echo $MKFS_OPTIONS | sed -rn 's/.*-b ?+([0-9]+).*/\1/p'`
>      if [ -z "$blksz" ]; then
> @@ -3090,6 +3096,10 @@ _check_udf_filesystem()
>  	_udf_test_known_error_filter | \
>  	grep -E -iv "Error count:.*[0-9]+.*total occurrences:.*[0-9]+|Warning count:.*[0-9]+.*total occurrences:.*[0-9]+" && \
>          echo "Warning UDF Verifier reported errors see $seqres.checkfs." && return 1
> +    # Remount the filesystem
> +    if [ "$type" = "$FSTYP" ]; then
> +	_mount_or_remount_rw "$MOUNT_OPTIONS" $device $mountpoint
> +    fi
>      return 0
>  }
>  

Looks fine.
Reviewed-by: David Disseldorp <ddiss@suse.de>