Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples

From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Lucas Stankus" <lucas.p.stankus@gmail.com>,
	"Puranjay Mohan" <puranjay12@gmail.com>,
	"Dmitry Rokosov" <ddrokosov@sberdevices.ru>,
	"Alexandru Tachici" <alexandru.tachici@analog.com>,
	"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
	"Renato Lui Geh" <renatogeh@gmail.com>,
	"Eugen Hristev" <eugen.hristev@microchip.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Andreas Klinger" <ak@it-klinger.de>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Kent Gustavsson" <kent@minoris.se>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Oleksij Rempel" <linux@rempel-privat.de>,
	kernel@pengutronix.de, "Nuno Sá" <nuno.sa@analog.com>,
	"Nishant Malpani" <nish.malpani25@gmail.com>,
	"Rui Miguel Silva" <rmfrfs@gmail.com>,
	"Dragos Bogdan" <dragos.bogdan@analog.com>,
	"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Stefan Popa" <stefan.popa@analog.com>,
	"Robert Yang" <decatf@gmail.com>,
	"Sean Nyekjaer" <sean@geanix.com>,
	"Artur Rojek" <contact@artur-rojek.eu>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Philippe Reynes" <tremyfr@yahoo.fr>,
	"Alexandru Lazar" <alazar@startmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Caleb Connolly" <caleb.connolly@linaro.org>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"Stefan Agner" <stefan@agner.ch>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Harald Geyer" <harald@ccbib.org>,
	"Eugene Zaikonnikov" <ez@norophonic.com>,
	"Phil Reid" <preid@electromag.com.au>,
	"Matt Ranostay" <matt.ranostay@konsulko.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Sankar Velliangiri" <navin@linumiz.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	chrome-platform@lists.linux.dev
Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples
Date: Sun, 22 Jan 2023 17:01:05 +0000	[thread overview]
Message-ID: <20230122170105.6a1a9766@jic23-huawei> (raw)
In-Reply-To: <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org>

On Sat, 21 Jan 2023 19:31:23 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 21/01/2023 18:17, Jonathan Cameron wrote:
> > On Wed, 18 Jan 2023 19:44:11 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >   
> >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
> >> examples.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---  
> >   
> >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> index 6c5ad426a016..12f75ddc4a70 100644
> >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> >> @@ -42,7 +42,7 @@ examples:
> >>          #address-cells = <1>;
> >>          #size-cells = <0>;
> >>  
> >> -        heart_mon@0 {
> >> +        heart-rate@0 {  
> > 
> > These are both heart-rate and pulse oximeters so measure more than just
> > the rate (oxygen saturation in the blood). Reality is they actually
> > measure light absorption over time, but you can calculate an estimate
> > of both rate and oxygen saturation from that.
> > 
> > I don't really mind simplifying that to heart-rate, but wanted to
> > call this out for possible discussion.  
> 
> They could be heart-mon. The fix is mostly around the underscore. I
> don't have any arguments for changing it to heart-rate, thus we can go
> with whatever you prefer.
I'm fine with either and as we have a patch with heart-rate that wins
currently. I'll just let this sit for a little longer than
normal to see if we get any other responses!

Thanks,

Jonathan
> 
> Best regards,
> Krzysztof
>