From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-riscv@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 00/19] hw: Set QDev properties using QDev API (part 1/3)
Date: Fri, 3 Feb 2023 19:08:55 +0100 [thread overview]
Message-ID: <20230203180914.49112-1-philmd@linaro.org> (raw)
QEMU provides the QOM API for core objects.
Devices are modelled on top of QOM as QDev objects.
There is no point in using the lower level QOM API with
QDev; it makes the code more complex and harder to review.
I first converted all the calls using errp=&error_abort or
&errp=NULL, then noticed the other uses weren't really
consistent.
A QDev property defined with the DEFINE_PROP_xxx() macros
is always available, thus can't fail. When using hot-plug
devices, we only need to check for optional properties
registered at runtime with the object_property_add_XXX()
API. Some are even always registered in device instance_init.
I have probably been overzealous, so I tagged the patches
not using errp=&error_abort|&error_fatal|NULL as RFC.
PPC and ARM conversions will follow as two different series.
Philippe Mathieu-Daudé (19):
scripts/coccinelle: Add qom-qdev-prop.cocci
hw/qdev: Introduce qdev_prop_set_link()
hw/acpi: Set QDev properties using QDev API
hw/audio: Set QDev properties using QDev API
hw/core/numa: Set QDev properties using QDev API
hw/core/gpio: Set QDev properties using QDev API
hw/scsi: Set QDev properties using QDev API
hw/usb: Set QDev properties using QDev API
hw/virtio: Set QDev properties using QDev API
hw/avr: Set QDev properties using QDev API
hw/hppa: Set QDev properties using QDev API
hw/i386: Set QDev properties using QDev API
hw/m68k: Set QDev properties using QDev API
hw/microblaze: Set QDev properties using QDev API
hw/mips: Set QDev properties using QDev API
hw/nios2: Set QDev properties using QDev API
hw/riscv: Set QDev properties using QDev API
hw/rx: Set QDev properties using QDev API
hw/sparc: Set QDev properties using QDev API
hw/acpi/cpu_hotplug.c | 7 ++--
hw/acpi/ich9.c | 4 +--
hw/acpi/piix4.c | 4 +--
hw/avr/arduino.c | 4 +--
hw/avr/atmega.c | 4 +--
hw/core/gpio.c | 8 ++---
hw/core/numa.c | 4 +--
hw/core/qdev-properties.c | 5 +++
hw/display/virtio-gpu-pci.c | 4 +--
hw/display/virtio-vga.c | 4 +--
hw/dma/sparc32_dma.c | 6 ++--
hw/hppa/machine.c | 3 +-
hw/i386/pc.c | 8 ++---
hw/i386/pc_q35.c | 25 +++++++-------
hw/i386/sgx.c | 3 +-
hw/i386/x86.c | 12 +++----
hw/m68k/next-cube.c | 2 +-
hw/m68k/q800.c | 7 ++--
hw/mem/pc-dimm.c | 5 ++-
hw/microblaze/petalogix_ml605_mmu.c | 40 ++++++++++------------
hw/microblaze/petalogix_s3adsp1800_mmu.c | 2 +-
hw/microblaze/xlnx-zynqmp-pmu.c | 40 +++++++++-------------
hw/mips/boston.c | 6 ++--
hw/mips/cps.c | 42 ++++++++----------------
hw/mips/jazz.c | 3 +-
hw/mips/malta.c | 6 ++--
hw/nios2/10m50_devboard.c | 2 +-
hw/riscv/microchip_pfsoc.c | 8 ++---
hw/riscv/opentitan.c | 9 ++---
hw/riscv/shakti_c.c | 7 ++--
hw/riscv/sifive_e.c | 8 ++---
hw/riscv/sifive_u.c | 9 ++---
hw/riscv/spike.c | 10 +++---
hw/riscv/virt.c | 9 ++---
hw/rx/rx-gdbsim.c | 11 +++----
hw/scsi/scsi-bus.c | 6 +---
hw/sparc/sun4m.c | 10 +++---
hw/sparc64/sun4u.c | 3 +-
hw/usb/hcd-xhci-pci.c | 2 +-
hw/usb/hcd-xhci-sysbus.c | 2 +-
hw/virtio/virtio-iommu-pci.c | 3 +-
hw/virtio/virtio-rng.c | 3 +-
include/hw/audio/pcspk.h | 2 +-
include/hw/qdev-properties.h | 1 +
target/i386/cpu.c | 6 ++--
target/i386/host-cpu.c | 7 ++--
46 files changed, 155 insertions(+), 221 deletions(-)
create mode 100644 scripts/coccinelle/qom-qdev-prop.cocci
--
2.38.1
next reply other threads:[~2023-02-03 18:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 18:08 Philippe Mathieu-Daudé [this message]
2023-02-03 18:08 ` [PATCH 01/19] NOTFORMERGE scripts/coccinelle: Add qom-qdev-prop.cocci Philippe Mathieu-Daudé
2023-02-03 18:08 ` [PATCH 02/19] hw/qdev: Introduce qdev_prop_set_link() Philippe Mathieu-Daudé
2023-02-05 22:53 ` Mark Cave-Ayland
2023-02-03 18:08 ` [PATCH 03/19] hw/acpi: Set QDev properties using QDev API Philippe Mathieu-Daudé
2023-03-01 14:07 ` Igor Mammedov
2023-02-03 18:08 ` [PATCH 04/19] hw/audio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 05/19] hw/core/numa: " Philippe Mathieu-Daudé
2023-03-01 14:09 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 06/19] hw/core/gpio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 07/19] hw/scsi: " Philippe Mathieu-Daudé
2023-03-01 14:13 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 08/19] hw/usb: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 09/19] hw/virtio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 10/19] hw/avr: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 11/19] hw/hppa: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 12/19] hw/i386: " Philippe Mathieu-Daudé
2023-02-04 13:23 ` Bernhard Beschow
2023-03-01 14:00 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 13/19] hw/m68k: " Philippe Mathieu-Daudé
2023-02-05 9:14 ` Thomas Huth
2023-02-03 18:09 ` [PATCH 14/19] hw/microblaze: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 15/19] hw/mips: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 16/19] hw/nios2: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 17/19] hw/riscv: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 18/19] hw/rx: " Philippe Mathieu-Daudé
2023-02-06 13:01 ` Yoshinori Sato
2023-02-03 18:09 ` [PATCH 19/19] hw/sparc: " Philippe Mathieu-Daudé
2023-02-03 18:12 ` [PATCH 00/19] hw: Set QDev properties using QDev API (part 1/3) Philippe Mathieu-Daudé
2023-02-03 18:52 ` BALATON Zoltan
2023-03-01 13:42 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203180914.49112-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.