All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Wolfram Sang <wsa@kernel.org>,
	linux-pm@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH 0/2] drivers/thermal/rcar_gen3_thermal: Fix device initialization
Date: Tue,  7 Feb 2023 18:10:09 +0100	[thread overview]
Message-ID: <20230207171011.1596127-1-niklas.soderlund+renesas@ragnatech.se> (raw)

Hello,

This small series fixes a window where incorrect values can be read from 
the driver before it is fully initialized. The root cause is that the 
thermal zone is register too early.

Patch 1/2 prepares for the change while also fixing a theoretical issue 
where one thermal node described in DT would describe interrupts and 
another would not. Resulting in interrupt support being disabled for 
both of them. I'm not aware of any case where this configuration would 
be used, either the SoC supports interrupts, or it don't.

While patch 2/2 fixes the real issue by fully initializing the device 
before registering the zone.

Niklas Söderlund (2):
  drivers/thermal/rcar_gen3_thermal: Create device local ops struct
  drivers/thermal/rcar_gen3_thermal: Fix device initialization

 drivers/thermal/rcar_gen3_thermal.c | 34 ++++++++++++++++-------------
 1 file changed, 19 insertions(+), 15 deletions(-)

-- 
2.39.1


             reply	other threads:[~2023-02-07 17:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 17:10 Niklas Söderlund [this message]
2023-02-07 17:10 ` [PATCH 1/2] drivers/thermal/rcar_gen3_thermal: Create device local ops struct Niklas Söderlund
2023-02-08  7:56   ` Wolfram Sang
2023-02-07 17:10 ` [PATCH 2/2] drivers/thermal/rcar_gen3_thermal: Fix device initialization Niklas Söderlund
2023-02-08  7:58   ` Wolfram Sang
2023-02-08 10:12     ` Niklas Söderlund
2023-02-08 14:14       ` Wolfram Sang
2023-02-08 11:06   ` Daniel Lezcano
2023-02-08 18:44     ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230207171011.1596127-1-niklas.soderlund+renesas@ragnatech.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.