[PATCH V3 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default()

From: Jon Hunter <jonathanh@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH V3 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default()
Date: Thu, 9 Feb 2023 12:53:19 +0000	[thread overview]
Message-ID: <20230209125319.18589-2-jonathanh@nvidia.com> (raw)
In-Reply-To: <20230209125319.18589-1-jonathanh@nvidia.com>

The function gether_setup_name_default() is called by various USB
ethernet gadget drivers. Calling this function will select a random
host and device MAC addresses. A properly working driver should be
silent and not warn the user about default MAC addresses selection.
Given that the MAC addresses are also printed when the function
gether_register_netdev() is called, remove these unnecessary warnings.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
V3: Updated patch to remove the prints completely.
V2: Changed print to debug instead of info.

 drivers/usb/gadget/function/u_ether.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 740331882e8d..953d936fbae6 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -811,13 +811,11 @@ struct net_device *gether_setup_name_default(const char *netname)
 	snprintf(net->name, sizeof(net->name), "%s%%d", netname);
 
 	eth_random_addr(dev->dev_mac);
-	pr_warn("using random %s ethernet address\n", "self");
 
 	/* by default we always have a random MAC address */
 	net->addr_assign_type = NET_ADDR_RANDOM;
 
 	eth_random_addr(dev->host_mac);
-	pr_warn("using random %s ethernet address\n", "host");
 
 	net->netdev_ops = &eth_netdev_ops;
 
-- 
2.34.1

