From: kernel test robot <lkp@intel.com>
To: Zqiang <qiang1.zhang@intel.com>,
paulmck@kernel.org, frederic@kernel.org,
quic_neeraju@quicinc.com, joel@joelfernandes.org,
qiuxu.zhuo@intel.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rcu: Keeping rcu-related kthreads running on housekeeping CPUS
Date: Thu, 9 Feb 2023 22:51:08 +0800 [thread overview]
Message-ID: <202302092209.AYjmQ4Id-lkp@intel.com> (raw)
In-Reply-To: <20230209102730.974465-1-qiang1.zhang@intel.com>
Hi Zqiang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on paulmck-rcu/dev]
[also build test WARNING on next-20230209]
[cannot apply to linus/master v6.2-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zqiang/rcu-Keeping-rcu-related-kthreads-running-on-housekeeping-CPUS/20230209-182311
base: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
patch link: https://lore.kernel.org/r/20230209102730.974465-1-qiang1.zhang%40intel.com
patch subject: [PATCH v2] rcu: Keeping rcu-related kthreads running on housekeeping CPUS
config: riscv-randconfig-r016-20230209 (https://download.01.org/0day-ci/archive/20230209/202302092209.AYjmQ4Id-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db0e6591612b53910a1b366863348bdb9d7d2fb1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/af15a3ade363b21d823918088623f8564cbd9d08
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zqiang/rcu-Keeping-rcu-related-kthreads-running-on-housekeeping-CPUS/20230209-182311
git checkout af15a3ade363b21d823918088623f8564cbd9d08
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302092209.AYjmQ4Id-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from kernel/torture.c:40:
>> kernel/rcu/rcu.h:509:6: warning: no previous prototype for function 'rcu_tasks_generic_setaffinity' [-Wmissing-prototypes]
void rcu_tasks_generic_setaffinity(int cpu) {}
^
kernel/rcu/rcu.h:509:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void rcu_tasks_generic_setaffinity(int cpu) {}
^
static
1 warning generated.
vim +/rcu_tasks_generic_setaffinity +509 kernel/rcu/rcu.h
484
485 #ifdef CONFIG_TINY_RCU
486 /* Tiny RCU doesn't expedite, as its purpose in life is instead to be tiny. */
487 static inline bool rcu_gp_is_normal(void) { return true; }
488 static inline bool rcu_gp_is_expedited(void) { return false; }
489 static inline bool rcu_async_should_hurry(void) { return false; }
490 static inline void rcu_expedite_gp(void) { }
491 static inline void rcu_unexpedite_gp(void) { }
492 static inline void rcu_async_hurry(void) { }
493 static inline void rcu_async_relax(void) { }
494 static inline void rcu_request_urgent_qs_task(struct task_struct *t) { }
495 #else /* #ifdef CONFIG_TINY_RCU */
496 bool rcu_gp_is_normal(void); /* Internal RCU use. */
497 bool rcu_gp_is_expedited(void); /* Internal RCU use. */
498 bool rcu_async_should_hurry(void); /* Internal RCU use. */
499 void rcu_expedite_gp(void);
500 void rcu_unexpedite_gp(void);
501 void rcu_async_hurry(void);
502 void rcu_async_relax(void);
503 void rcupdate_announce_bootup_oddness(void);
504 #ifdef CONFIG_TASKS_RCU_GENERIC
505 void show_rcu_tasks_gp_kthreads(void);
506 void rcu_tasks_generic_setaffinity(int cpu);
507 #else /* #ifdef CONFIG_TASKS_RCU_GENERIC */
508 static inline void show_rcu_tasks_gp_kthreads(void) {}
> 509 void rcu_tasks_generic_setaffinity(int cpu) {}
510 #endif /* #else #ifdef CONFIG_TASKS_RCU_GENERIC */
511 void rcu_request_urgent_qs_task(struct task_struct *t);
512 #endif /* #else #ifdef CONFIG_TINY_RCU */
513
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-09 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 10:27 [PATCH v2] rcu: Keeping rcu-related kthreads running on housekeeping CPUS Zqiang
2023-02-09 12:59 ` kernel test robot
2023-02-09 14:51 ` kernel test robot [this message]
2023-02-09 15:21 ` kernel test robot
2023-02-10 0:32 ` Frederic Weisbecker
2023-02-10 5:26 ` Zhang, Qiang1
2023-02-15 14:51 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302092209.AYjmQ4Id-lkp@intel.com \
--to=lkp@intel.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=qiang1.zhang@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.