From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: kuba@kernel.org, davem@davemloft.net, wg@grandegger.com,
edumazet@google.com, pabeni@redhat.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] can: mscan: mpc5xxx: Use of_property_present() helper
Date: Tue, 21 Feb 2023 09:42:06 +0100 [thread overview]
Message-ID: <20230221084206.zxnyanfoox4gqghm@pengutronix.de> (raw)
In-Reply-To: <20230221024541.105199-1-yang.lee@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On 21.02.2023 10:45:41, Yang Li wrote:
> Use of_property_present() instead of of_get_property/of_find_property()
> in places where we just need to test presence of a property.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
NAK!
Besides the things Pavan Chebbi says, this is not even compile:
| drivers/net/can/mscan/mpc5xxx_can.c: In function ‘mpc5xxx_can_probe’:
| drivers/net/can/mscan/mpc5xxx_can.c:318:22: error: implicit declaration of function ‘of_property_present’; did you mean ‘fwnode_property_present’? [-Werror=implicit-function-declaration]
| 318 | clock_name = of_property_present(np, "fsl,mscan-clock-source");
| | ^~~~~~~~~~~~~~~~~~~
| | fwnode_property_present
| drivers/net/can/mscan/mpc5xxx_can.c:318:20: error: assignment to ‘const char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
| 318 | clock_name = of_property_present(np, "fsl,mscan-clock-source");
| | ^
| cc1: all warnings being treated as errors
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-02-21 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 2:45 [PATCH -next] can: mscan: mpc5xxx: Use of_property_present() helper Yang Li
2023-02-21 4:35 ` Pavan Chebbi
2023-02-21 8:42 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221084206.zxnyanfoox4gqghm@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wg@grandegger.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.