From: Xenia Ragiadakou <burzalodowa@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: "Jun Nakajima" <jun.nakajima@intel.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>
Subject: [PATCH v2 4/9] x86/vmx: remove unused included headers from vmx.h
Date: Wed, 22 Feb 2023 14:00:18 +0200 [thread overview]
Message-ID: <20230222120023.3004624-5-burzalodowa@gmail.com> (raw)
In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com>
Do not include the headers:
asm/i387.h
asm/hvm/trace.h
asm/processor.h
asm/regs.h
because none of the declarations and macro definitions in them is used in
this file. Sort the rest of the headers alphabetically.
Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy().
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
Changes in v2:
-add a blank line between different types of headers, reported by Andrew
-fix english in commit message, reported by Andrew
xen/arch/x86/hvm/vmx/vmx.c | 1 +
xen/arch/x86/include/asm/hvm/vmx/vmx.h | 9 +++------
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 0ec33bcc18..a0297e8c6c 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -43,6 +43,7 @@
#include <asm/hvm/vmx/vmcs.h>
#include <public/sched.h>
#include <public/hvm/ioreq.h>
+#include <asm/i387.h>
#include <asm/hvm/vpic.h>
#include <asm/hvm/vlapic.h>
#include <asm/x86_emulate.h>
diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
index 97d6b810ec..c0ca6d10e3 100644
--- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
+++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
@@ -19,14 +19,11 @@
#define __ASM_X86_HVM_VMX_VMX_H__
#include <xen/sched.h>
-#include <asm/types.h>
-#include <asm/regs.h>
+
#include <asm/asm_defns.h>
-#include <asm/processor.h>
-#include <asm/p2m.h>
-#include <asm/i387.h>
-#include <asm/hvm/trace.h>
#include <asm/hvm/vmx/vmcs.h>
+#include <asm/p2m.h>
+#include <asm/types.h>
extern int8_t opt_ept_exec_sp;
--
2.37.2
next prev parent reply other threads:[~2023-02-22 12:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 12:00 [PATCH v2 0/9] x86/hvm: {svm,vmx}.{c,h} cleanup Xenia Ragiadakou
2023-02-22 12:00 ` [PATCH v2 1/9] x86/svm: remove unused forward declaration of struct vcpu from svm.h Xenia Ragiadakou
2023-02-22 12:59 ` Jan Beulich
2023-02-23 10:50 ` Andrew Cooper
2023-02-23 11:00 ` Xenia Ragiadakou
2023-02-22 12:00 ` [PATCH v2 2/9] x86/svm: opencode SVM_PAUSE{FILTER,THRESH}_INIT Xenia Ragiadakou
2023-02-23 10:19 ` Jan Beulich
2023-02-22 12:00 ` [PATCH v2 3/9] x86/svm: move declarations used only by svm code from svm.h to private header Xenia Ragiadakou
2023-02-23 10:24 ` Jan Beulich
2023-02-23 11:16 ` Andrew Cooper
2023-02-23 14:40 ` Xenia Ragiadakou
2023-02-22 12:00 ` Xenia Ragiadakou [this message]
2023-02-23 10:29 ` [PATCH v2 4/9] x86/vmx: remove unused included headers from vmx.h Jan Beulich
2023-02-23 10:42 ` Xenia Ragiadakou
2023-02-22 12:00 ` [PATCH v2 5/9] x86/vmx: reduce scope of GAS_VMX_OP definition Xenia Ragiadakou
2023-02-23 10:31 ` Jan Beulich
2023-02-23 10:45 ` Xenia Ragiadakou
2023-02-22 12:00 ` [PATCH v2 6/9] x86/vmx: move declations used only by vmx code from vmx.h to private header Xenia Ragiadakou
2023-02-23 10:47 ` Jan Beulich
2023-02-23 11:56 ` Andrew Cooper
2023-02-24 7:49 ` Xenia Ragiadakou
2023-02-24 8:26 ` Jan Beulich
2023-02-22 12:00 ` [PATCH v2 7/9] x86/vmx: remove unused included headers from vmx.c Xenia Ragiadakou
2023-02-23 11:16 ` Jan Beulich
2023-02-22 12:00 ` [PATCH v2 8/9] x86/vmx: declare nvmx_enqueue_n2_exceptions() static Xenia Ragiadakou
2023-02-23 11:19 ` Jan Beulich
2023-02-22 12:00 ` [PATCH v2 9/9] x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static Xenia Ragiadakou
2023-02-23 11:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222120023.3004624-5-burzalodowa@gmail.com \
--to=burzalodowa@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.