Re: [PATCH v2 2/8] platform/x86: ISST: Enumerate TPMI SST and create framework

From: kernel test robot <lkp@intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 2/8] platform/x86: ISST: Enumerate TPMI SST and create framework
Date: Wed, 8 Mar 2023 21:18:17 +0800	[thread overview]
Message-ID: <202303082101.fF7OWAtH-lkp@intel.com> (raw)
In-Reply-To: <20230308070642.1727167-3-srinivas.pandruvada@linux.intel.com>

Hi Srinivas,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.3-rc1 next-20230308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivas-Pandruvada/platform-x86-ISST-Add-support-for-MSR-0x54/20230308-150906
patch link:    https://lore.kernel.org/r/20230308070642.1727167-3-srinivas.pandruvada%40linux.intel.com
patch subject: [PATCH v2 2/8] platform/x86: ISST: Enumerate TPMI SST and create framework
config: x86_64-randconfig-a016-20230306 (https://download.01.org/0day-ci/archive/20230308/202303082101.fF7OWAtH-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2e4ff37ca5561b5d2ff368395f8d5d043a684ca5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Srinivas-Pandruvada/platform-x86-ISST-Add-support-for-MSR-0x54/20230308-150906
        git checkout 2e4ff37ca5561b5d2ff368395f8d5d043a684ca5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303082101.fF7OWAtH-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:245:5: error: no member named 'api_version' in 'struct isst_if_cmd_cb'
           cb.api_version = ISST_TPMI_API_VERSION;
           ~~ ^
>> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:246:5: error: no member named 'def_ioctl' in 'struct isst_if_cmd_cb'
           cb.def_ioctl = isst_if_def_ioctl;
           ~~ ^
>> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:248:30: error: use of undeclared identifier 'ISST_IF_DEV_TPMI'
           ret = isst_if_cdev_register(ISST_IF_DEV_TPMI, &cb);
                                       ^
   drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:264:27: error: use of undeclared identifier 'ISST_IF_DEV_TPMI'
                   isst_if_cdev_unregister(ISST_IF_DEV_TPMI);
                                           ^
   4 errors generated.

vim +245 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c

   222	
   223	int tpmi_sst_init(void)
   224	{
   225		struct isst_if_cmd_cb cb;
   226		int ret = 0;
   227	
   228		mutex_lock(&isst_tpmi_dev_lock);
   229	
   230		if (isst_core_usage_count) {
   231			++isst_core_usage_count;
   232			goto init_done;
   233		}
   234	
   235		isst_common.sst_inst = kcalloc(topology_max_packages(),
   236					       sizeof(*isst_common.sst_inst),
   237					       GFP_KERNEL);
   238		if (!isst_common.sst_inst)
   239			return -ENOMEM;
   240	
   241		memset(&cb, 0, sizeof(cb));
   242		cb.cmd_size = sizeof(struct isst_if_io_reg);
   243		cb.offset = offsetof(struct isst_if_io_regs, io_reg);
   244		cb.cmd_callback = NULL;
 > 245		cb.api_version = ISST_TPMI_API_VERSION;
 > 246		cb.def_ioctl = isst_if_def_ioctl;
   247		cb.owner = THIS_MODULE;
 > 248		ret = isst_if_cdev_register(ISST_IF_DEV_TPMI, &cb);
   249		if (ret)
   250			kfree(isst_common.sst_inst);
   251	init_done:
   252		mutex_unlock(&isst_tpmi_dev_lock);
   253		return ret;
   254	}
   255	EXPORT_SYMBOL_NS_GPL(tpmi_sst_init, INTEL_TPMI_SST);
   256	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests