From: kernel test robot <lkp@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
mcanal@igalia.com, stanislaw.gruszka@linux.intel.com,
ogabbay@kernel.org, quic_jhugo@quicinc.com, daniel@ffwll.ch,
jani.nikula@linux.intel.com, mwen@igalia.com, maxime@cerno.tech,
wambui.karugax@gmail.com, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM
Date: Fri, 17 Mar 2023 06:58:29 +0800 [thread overview]
Message-ID: <202303170635.A2RsQ1Wu-lkp@intel.com> (raw)
In-Reply-To: <20230316082035.567520-3-christian.koenig@amd.com>
Hi Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next]
[cannot apply to drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230316082035.567520-3-christian.koenig%40amd.com
patch subject: [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM
config: mips-allmodconfig (https://download.01.org/0day-ci/archive/20230317/202303170635.A2RsQ1Wu-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8a2dbd34b0290b78a1ac2252d451abbcbcd50666
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
git checkout 8a2dbd34b0290b78a1ac2252d451abbcbcd50666
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/tegra/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303170635.A2RsQ1Wu-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_mmap':
>> drivers/gpu/drm/tegra/gem.c:188:24: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
188 | return vmap(obj->pages, obj->num_pages, VM_MAP,
| ^~~~
| kmap
>> drivers/gpu/drm/tegra/gem.c:188:57: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'?
188 | return vmap(obj->pages, obj->num_pages, VM_MAP,
| ^~~~~~
| VM_MTE
drivers/gpu/drm/tegra/gem.c:188:57: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_munmap':
>> drivers/gpu/drm/tegra/gem.c:203:17: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
203 | vunmap(addr);
| ^~~~~~
| kunmap
drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_mmap':
drivers/gpu/drm/tegra/gem.c:191:1: error: control reaches end of non-void function [-Werror=return-type]
191 | }
| ^
cc1: some warnings being treated as errors
--
drivers/gpu/drm/tegra/fb.c: In function 'tegra_fbdev_probe':
>> drivers/gpu/drm/tegra/fb.c:276:29: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
276 | bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
| ^~~~
| kmap
>> drivers/gpu/drm/tegra/fb.c:276:60: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'?
276 | bo->vaddr = vmap(bo->pages, bo->num_pages, VM_MAP,
| ^~~~~~
| VM_MTE
drivers/gpu/drm/tegra/fb.c:276:60: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/tegra/fb.c: In function 'tegra_fbdev_exit':
>> drivers/gpu/drm/tegra/fb.c:359:25: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
359 | vunmap(bo->vaddr);
| ^~~~~~
| kunmap
cc1: some warnings being treated as errors
vim +188 drivers/gpu/drm/tegra/gem.c
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 175
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 176 static void *tegra_bo_mmap(struct host1x_bo *bo)
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 177 {
3be8274341499cf drivers/gpu/host1x/drm/gem.c Thierry Reding 2013-09-24 178 struct tegra_bo *obj = host1x_to_tegra_bo(bo);
7938f4218168ae9 drivers/gpu/drm/tegra/gem.c Lucas De Marchi 2022-02-04 179 struct iosys_map map;
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 180 int ret;
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 181
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 182 if (obj->vaddr) {
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 183 return obj->vaddr;
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 184 } else if (obj->gem.import_attach) {
f66d48c8cc8d996 drivers/gpu/drm/tegra/gem.c Dmitry Osipenko 2022-10-17 185 ret = dma_buf_vmap_unlocked(obj->gem.import_attach->dmabuf, &map);
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 186 return ret ? NULL : map.vaddr;
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 187 } else {
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 @188 return vmap(obj->pages, obj->num_pages, VM_MAP,
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 189 pgprot_writecombine(PAGE_KERNEL));
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 190 }
6619ccf1bb1d0eb drivers/gpu/drm/tegra/gem.c Thomas Zimmermann 2020-09-25 191 }
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 192
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 193 static void tegra_bo_munmap(struct host1x_bo *bo, void *addr)
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 194 {
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 195 struct tegra_bo *obj = host1x_to_tegra_bo(bo);
7938f4218168ae9 drivers/gpu/drm/tegra/gem.c Lucas De Marchi 2022-02-04 196 struct iosys_map map = IOSYS_MAP_INIT_VADDR(addr);
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 197
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 198 if (obj->vaddr)
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 199 return;
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 200 else if (obj->gem.import_attach)
f66d48c8cc8d996 drivers/gpu/drm/tegra/gem.c Dmitry Osipenko 2022-10-17 201 dma_buf_vunmap_unlocked(obj->gem.import_attach->dmabuf, &map);
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 202 else
7ecada3cc44798c drivers/gpu/drm/tegra/gem.c Arto Merilainen 2016-11-08 @203 vunmap(addr);
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 204 }
de2ba664c30fcdb drivers/gpu/host1x/drm/gem.c Arto Merilainen 2013-03-22 205
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-16 22:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 8:20 DRM debugfs cleanup take 3 Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 8:20 ` [PATCH 1/7] drm: remove drm_dev_set_unique Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 14:15 ` Jeffrey Hugo
2023-03-16 14:15 ` [Intel-gfx] " Jeffrey Hugo
2023-03-16 8:20 ` [PATCH 2/7] drm/tegra: allow compile test on !ARM Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 22:58 ` kernel test robot [this message]
2023-03-16 8:20 ` [PATCH 3/7] drm/debugfs: stop calling debugfs_init() for the render node Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 8:20 ` [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2 Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 22:27 ` kernel test robot
2023-03-22 11:17 ` Stanislaw Gruszka
2023-03-22 11:17 ` [Intel-gfx] " Stanislaw Gruszka
2023-03-16 8:20 ` [PATCH 5/7] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 8:20 ` [Intel-gfx] [PATCH 6/7] drm/debugfs: rework drm_debugfs_create_files implementation Christian König
2023-03-16 8:20 ` Christian König
2023-03-16 8:20 ` [PATCH 7/7] drm/debugfs: remove debugfs_root pointer from minor Christian König
2023-03-16 8:20 ` [Intel-gfx] " Christian König
2023-03-16 11:24 ` kernel test robot
2023-03-16 11:24 ` [Intel-gfx] " kernel test robot
2023-03-16 8:25 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/7] drm: remove drm_dev_set_unique Patchwork
2023-03-22 11:58 ` Jani Nikula
2023-03-22 13:51 ` Christian König
2023-03-22 11:20 ` DRM debugfs cleanup take 3 Stanislaw Gruszka
2023-03-22 11:20 ` [Intel-gfx] " Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303170635.A2RsQ1Wu-lkp@intel.com \
--to=lkp@intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=mwen@igalia.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.