From: Herve Codina <herve.codina@bootlin.com>
To: Tom Rix <trix@redhat.com>
Cc: gregkh@linuxfoundation.org, nathan@kernel.org,
ndesaulniers@google.com, linux-renesas-soc@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset function
Date: Sun, 19 Mar 2023 19:24:05 +0100 [thread overview]
Message-ID: <20230319192405.6202ea2b@bootlin.com> (raw)
In-Reply-To: <20230319155910.1706294-1-trix@redhat.com>
Hi Tom,
On Sun, 19 Mar 2023 11:59:10 -0400
Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function
> 'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function]
> static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/gadget/udc/renesas_usbf.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
> index cb23e62e8a87..84ac9fe4ce7f 100644
> --- a/drivers/usb/gadget/udc/renesas_usbf.c
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset,
> usbf_ep_dma_reg_writel(ep, offset, tmp);
> }
>
> -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
> - u32 clr, u32 set)
> -{
> - u32 tmp;
> -
> - tmp = usbf_ep_dma_reg_readl(ep, offset);
> - tmp &= ~clr;
> - tmp |= set;
> - usbf_ep_dma_reg_writel(ep, offset, tmp);
> -}
> -
> static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1)
> {
> u32 set;
Yes, indeed.
Acked-by: Herve Codina <herve.codina@bootlin.com>
Thanks for the patch.
Regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-03-19 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:59 [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset function Tom Rix
2023-03-19 18:24 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319192405.6202ea2b@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.